-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(genai): SDKupdate #13684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): SDKupdate #13684
Conversation
Summary of ChangesHello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine maintenance task: updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the google-genai SDK to version 1.56.0 across numerous samples. Many of these updates represent significant version jumps, such as from 1.7.0 to 1.56.0, which are likely to introduce breaking API changes. It is crucial to ensure that these dependency updates do not negatively impact the functionality of the samples. The pull request description indicates that tests may not have been run, which is a concern. I have added a specific comment highlighting the risk on one of the files with the largest version jump, but this concern applies to all the requirements.txt files modified in this PR. Please ensure that all tests are passing before this pull request is merged to maintain the correctness and reliability of the code samples.
| @@ -1 +1 @@ | |||
| google-genai==1.7.0 No newline at end of file | |||
| google-genai==1.56.0 No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very large version jump for the google-genai package, from 1.7.0 to 1.56.0. Such a significant update is likely to include breaking changes that could affect the functionality of the Anthropic model samples. It is crucial to run comprehensive tests to ensure compatibility and prevent potential runtime errors for users of this sample.
cfloress
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)