Conversation
product-auto-label
bot
added
samples
davidcavazos
added
the
do not merge
|
|
||
| func Affected(config Config, diffs []string) ([]string, error) { | ||
| changed := Changed(config, diffs) | ||
| if slices.Contains(changed, ".") { |
There was a problem hiding this comment.
Wow is this new fancy slices packages nice. Back in my day ... ;D.
[No action required]
telpirion
left a comment
telpirion
left a comment
There was a problem hiding this comment.
Looking really good! I will probably take another look at the parallelized code in RunAll() (but it looks solid prima facie).
Global: make sure that exported types, functions, and methods all have Godoc comments.
…ples into testing-isolation
telpirion
left a comment
telpirion
left a comment
There was a problem hiding this comment.
Very nicely done. One minor nit, but otherwise--let's ship it!
There was a problem hiding this comment.
nit (very minor): Go style is to keep tests and the code under test together.
| ) | ||
|
|
||
| func TestLoadConfig(t *testing.T) { | ||
| tests := []struct { |
There was a problem hiding this comment.
Great use of table testing!
|
Moved tests into the source directory, updated README as well. |
|
@gemini review |
1 similar comment
|
@gemini review |
davidcavazos
removed
the
do not merge
5 participants
Description
This is an effort to speed up checks for pull requests, while at the same time simplifying the existing testing infrastructure in Node.js by using a dynamic strategy matrix.
Note: We're currently not using the
run-allcommand, that's infrastructure that will eventually be used to optimize the nightly jobs.These new tests are marked as
experimental, so they shouldn't block any pull requests from merging. Once we have all the tests working on the new infrastructure and we feel comfortable with it, we can go ahead and disable the old tests.Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.