Skip to content

Conversation

@nicdumz
Copy link
Contributor

@nicdumz nicdumz commented Dec 24, 2025

Instead of always setting create/update/delete as async, only set it if x-google-lro is set.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@slevenick slevenick marked this pull request as ready for review December 30, 2025 22:34
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm merging this as I'm currently writing support for singleton resources and this will be useful for me

@slevenick slevenick added this pull request to the merge queue Dec 30, 2025
@github-actions github-actions bot requested a review from slevenick December 30, 2025 22:35
Merged via the queue into GoogleCloudPlatform:main with commit cba1159 Dec 30, 2025
26 checks passed
abhijeetkjha-google pushed a commit to abhijeetkjha-google/magic-modules that referenced this pull request Jan 2, 2026
@nicdumz nicdumz deleted the x-google-lro branch January 5, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants