chore(aiplatform): Update CreateBatchPredictionGeminiBigqueryJobSample to use gemini 2.5#10229
Conversation
…e to use gemini 2.5
Summary of ChangesHello @amcolin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates a Java sample for Google Cloud AI Platform to ensure it uses a current and supported version of the Gemini model. The change specifically targets the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Gemini model version to gemini-2.5-flash in CreateBatchPredictionGeminiBigqueryJobSample.java. However, a related sample file, aiplatform/src/main/java/aiplatform/batchpredict/CreateBatchPredictionGeminiJobSample.java, still references the outdated gemini-2.0-flash-001 model. To ensure consistency and that all samples use the supported model version as stated in the PR description, I recommend updating the model in that file as well. After updating both files, consider extracting the model version string into a shared constant to improve maintainability and avoid duplication.
Description
The sample uses an outdated or inconsistent Gemini model version (gemini-2.0-flash-001). It needs to be updated to a supported version like gemini-2.5-flash
Internal: b/481401081
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only