feat!: introduce image gallery state store #3330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SDK Size
|
khushal87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the image gallery to simplify state management and remove legacy props and logic related to image gallery behavior. The main improvement is the introduction of a centralized
imageGalleryStateStore, which replaces the previous pattern of passing multiple state setters and props.Additionally, the video is now managed by a pool and a player class same as audio. This is for easy state management and ease of usage.
Additionally, the dependency on
@gorhom/bottom-sheetis updated, and related code is streamlined to use the new approach.Refactoring and State Management Improvements:
setMessages,setSelectedMessage,legacyImageViewerSwipeBehaviour) inGallery,Giphy, and related components with a singleimageGalleryStateStoreprop, centralizing image gallery state handling. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]imageGalleryStateStore.openImageGallery, removing conditional logic for legacy behavior. [1] [2]legacyImageViewerSwipeBehaviourfrom the codebase, including context, props, and hooks. [1] [2] [3] [4] [5]Dependency and Import Updates:
@gorhom/bottom-sheetdependency from version 5.1.8 to 5.2.8.ImageGallery.tsxto use the newimageGalleryStateStoreand removed unused imports and legacy bottom sheet modal code. [1] [2] [3]These changes modernize and simplify the gallery and attachment components, making state management more robust and maintainable.