Skip to content

Next Release #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isekovanic merged 2 commits into from
Nov 22, 2025
Merged

Next Release #3296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
febb234
fix: swipability regression
isekovanic Nov 22, 2025
ed9e953
Merge pull request #3295 from GetStream/fix/swipable-bubble-bug
isekovanic Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 8 additions & 25 deletions package/src/components/Message/MessageSimple/MessageBubble.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,8 @@ export const SwipableMessageBubble = React.memo(
'shouldRenderSwipeableWrapper' | 'messageSwipeToReplyHitSlop'
> & { onSwipe: () => void },
) => {
const {
MessageSwipeContent,
shouldRenderSwipeableWrapper,
messageSwipeToReplyHitSlop,
onSwipe,
...messageBubbleProps
} = props;
const { MessageSwipeContent, messageSwipeToReplyHitSlop, onSwipe, ...messageBubbleProps } =
props;

const {
theme: {
Expand All @@ -96,9 +91,7 @@ export const SwipableMessageBubble = React.memo(
const translateX = useSharedValue(0);
const touchStart = useSharedValue<{ x: number; y: number } | null>(null);
const isSwiping = useSharedValue<boolean>(false);
const [shouldRenderAnimatedWrapper, setShouldRenderAnimatedWrapper] = useState<boolean>(
shouldRenderSwipeableWrapper,
);
const [shouldRenderAnimatedWrapper, setShouldRenderAnimatedWrapper] = useState<boolean>(false);

const SWIPABLE_THRESHOLD = 25;
const MINIMUM_DISTANCE = 8;
Expand Down Expand Up @@ -134,10 +127,10 @@ export const SwipableMessageBubble = React.memo(
// Only activate if there's significant horizontal movement
if (isHorizontalPanning && hasMinimumDistance) {
state.activate();
isSwiping.value = true;
if (!shouldRenderSwipeableWrapper) {
runOnJS(setShouldRenderAnimatedWrapper)(isSwiping.value);
if (!isSwiping.value) {
runOnJS(setShouldRenderAnimatedWrapper)(true);
}
isSwiping.value = true;
} else if (hasMinimumDistance) {
// If there's significant movement but not horizontal, fail the gesture
state.fail();
Expand Down Expand Up @@ -168,21 +161,11 @@ export const SwipableMessageBubble = React.memo(
stiffness: 1,
},
() => {
if (!shouldRenderSwipeableWrapper) {
runOnJS(setShouldRenderAnimatedWrapper)(isSwiping.value);
}
runOnJS(setShouldRenderAnimatedWrapper)(false);
},
);
}),
[
messageSwipeToReplyHitSlop,
touchStart,
isSwiping,
shouldRenderSwipeableWrapper,
translateX,
onSwipe,
triggerHaptic,
],
[messageSwipeToReplyHitSlop, touchStart, isSwiping, translateX, onSwipe, triggerHaptic],
);

const swipeContentAnimatedStyle = useAnimatedStyle(
Expand Down
Loading