Move offline support to LLC #6062
Open
+905
−2,552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
DB Entities have been updated. Do we need to upgrade DB Version? |
Contributor
SDK Size Comparison 📏
|
gpunto
approved these changes
Jan 5, 2026
Comment on lines
-4894
to
+4898
| this.pluginFactories.addAll(pluginFactories) | ||
| this.pluginFactories = pluginFactories.toList() |
Contributor
There was a problem hiding this comment.
Should we update the KDoc since now we're overwriting the factories instead of adding them?
Contributor
Author
There was a problem hiding this comment.
I will update it!
Although after the refactor of offline/state, I would personally remove this method - I don't think we should allow registering custom plugins. (but we can discuss that separately)
# Conflicts: # metrics/size.json # stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api/OfflineConfig.kt # stream-chat-android-offline/src/main/AndroidManifest.xml # stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/database/internal/ChatDatabase.kt # stream-chat-android-offline/src/test/java/io/getstream/chat/android/offline/utils/ChannelDiffCallback.kt # stream-chat-android-offline/src/test/java/io/getstream/chat/android/offline/utils/DiffUtilOperationCounter.kt # stream-chat-android-offline/src/test/java/io/getstream/chat/android/offline/utils/MessageDiffCallback.kt # stream-chat-android-offline/src/test/java/io/getstream/chat/android/offline/utils/MockDatabase.kt # stream-chat-android-offline/src/test/java/io/getstream/chat/android/offline/utils/TestLoggerHandler.kt # stream-chat-android-offline/src/test/java/io/getstream/chat/android/offline/utils/TestUtils.kt
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Removes the
stream-chat-android-offlinemodule and moves theStreamOfflinePluginFactory/OfflinePluginto the LLC(stream-chat-android-client).Important: This is just the first part of the offline support refactor. The next step is to move the
statesupport down to the client. Afterwards, we need to revisit the points documented in the following ticket. This is extremely important before publishingV7.🛠 Implementation details
clientmodule, in package:io.getstream.chat.android.client.internal.offlineStreamOfflinePluginFactoryis nowinternalinstead of public to disallow instantiationOfflineConfigclass, via theChatClient.Builder.offlineConfig(OfflineConfig)methodChatClientrelated to the plugin setup - but in the end, theOfflinePluginis still setup internally based on theOfflineConfig.🎨 UI Changes
NA
🧪 Testing
The offline support is now enabled by default.
You can test that everything works as expected without any changes in the samples.
ChatClient.Builder().offlineSupport(OfflineConfig(enabled = false))- and verify that no data is available offline.