Test/ci patch by panquez · Pull Request #1248 · Geode-solutions/OpenGeode

panquez · 2026-03-13T11:42:37Z

No description provided.

github-actions · 2026-03-13T11:52:53Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 258 concern(s)

src/geode/geometry/distance.cpp:91:9: warning: [readability-use-std-min-max]

use std::max instead of <=

   24 |         if( area2 <= 0 )
      |         ^~~~~~~~~~~~~~~~
      |         area2 = std::max<double>(area2, 0);
   25 |         {
      |         ~
   26 |             area2 = 0;
      |             ~~~~~~~~~~
   27 |         }
      |         ~

src/geode/geometry/distance.cpp:98:45: warning: [readability-identifier-length]

parameter name 'b1' is too short, expected at least 3 characters

   98 |     void get_min_edge02( double a11, double b1, std::array< double, 2 >& p )
      |                                             ^

src/geode/geometry/distance.cpp:98:74: warning: [readability-identifier-length]

parameter name 'p' is too short, expected at least 3 characters

   98 |     void get_min_edge02( double a11, double b1, std::array< double, 2 >& p )
      |                                                                          ^

src/geode/geometry/distance.cpp:115:10: warning: [readability-function-size]

function 'get_min_edge12' exceeds recommended size/complexity thresholds

  115 |     void get_min_edge12( double a01,
      |          ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:115:10: note: 6 parameters (threshold 4)

src/geode/geometry/distance.cpp:115:26: warning: [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'get_min_edge12' of similar type ('double') are easily swapped by mistake

  115 |     void get_min_edge12( double a01,
      |                          ^~~~~~~~~~~
  116 |         double a11,
      |         ~~~~~~~~~~
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:115:33: note: the first parameter in the range is 'a01'
  115 |     void get_min_edge12( double a01,
      |                                 ^~~
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:116:16: note: the last parameter in the range is 'a11'
  116 |         double a11,
      |                ^~~

src/geode/geometry/distance.cpp:117:16: warning: [readability-identifier-length]

parameter name 'b1' is too short, expected at least 3 characters
```
  117 |         double b1,
      |                ^
```

src/geode/geometry/distance.cpp:118:9: warning: [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'get_min_edge12' of similar type ('double') are easily swapped by mistake

  118 |         double f10,
      |         ^~~~~~~~~~~
  119 |         double f01,
      |         ~~~~~~~~~~
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:118:16: note: the first parameter in the range is 'f10'
  118 |         double f10,
      |                ^~~
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:119:16: note: the last parameter in the range is 'f01'
  119 |         double f01,
      |                ^~~

src/geode/geometry/distance.cpp:120:34: warning: [readability-identifier-length]

parameter name 'p' is too short, expected at least 3 characters
```
  120 |         std::array< double, 2 >& p )
      |                                  ^
```
src/geode/geometry/distance.cpp:122:20: warning: [readability-identifier-length]

variable name 'h0' is too short, expected at least 3 characters
```
  122 |         const auto h0 = a01 + b1 - f10;
      |                    ^
```
src/geode/geometry/distance.cpp:129:24: warning: [readability-identifier-length]

variable name 'h1' is too short, expected at least 3 characters
```
  129 |             const auto h1 = a11 + b1 - f01;
      |                        ^
```

src/geode/geometry/distance.cpp:142:10: warning: [readability-function-size]

function 'get_min_interior' exceeds recommended size/complexity thresholds

  142 |     void get_min_interior( const std::array< double, 2 >& p0,
      |          ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:142:10: note: 5 parameters (threshold 4)

src/geode/geometry/distance.cpp:142:59: warning: [readability-identifier-length]

parameter name 'p0' is too short, expected at least 3 characters

  142 |     void get_min_interior( const std::array< double, 2 >& p0,
      |                                                           ^

src/geode/geometry/distance.cpp:143:16: warning: [readability-identifier-length]

parameter name 'h0' is too short, expected at least 3 characters
```
  143 |         double h0,
      |                ^
```
src/geode/geometry/distance.cpp:144:40: warning: [readability-identifier-length]

parameter name 'p1' is too short, expected at least 3 characters
```
  144 |         const std::array< double, 2 >& p1,
      |                                        ^
```
src/geode/geometry/distance.cpp:145:16: warning: [readability-identifier-length]

parameter name 'h1' is too short, expected at least 3 characters
```
  145 |         double h1,
      |                ^
```
src/geode/geometry/distance.cpp:146:34: warning: [readability-identifier-length]

parameter name 'p' is too short, expected at least 3 characters
```
  146 |         std::array< double, 2 >& p )
      |                                  ^
```
src/geode/geometry/distance.cpp:148:20: warning: [readability-identifier-length]

variable name 'z' is too short, expected at least 3 characters
```
  148 |         const auto z = h0 / ( h0 - h1 );
      |                    ^
```
src/geode/geometry/distance.cpp:186:13: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  186 |             edge_distances[e] = point_segment_distance_using_projection(
      |             ^
```
src/geode/geometry/distance.cpp:187:26: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  187 |                 point, { vertices[e], vertices[next] } );
      |                          ^
```
src/geode/geometry/distance.cpp:187:39: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  187 |                 point, { vertices[e], vertices[next] } );
      |                                       ^
```
src/geode/geometry/distance.cpp:188:55: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  188 |             const auto& cur_distance = std::get< 0 >( edge_distances[e] );
      |                                                       ^
```
src/geode/geometry/distance.cpp:195:16: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  195 |         return edge_distances[selected_edge];
      |                ^
```

src/geode/geometry/distance.cpp:198:42: warning: [readability-function-cognitive-complexity]

function 'pivot_point_triangle_distance' has cognitive complexity of 44 (threshold 10)

  198 |     std::tuple< double, geode::Point3D > pivot_point_triangle_distance(
      |                                          ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:204:33: note: +1, including nesting penalty of 0, nesting level increased to 1
  204 |         const auto v1 = v0 == 2 ? 0 : v0 + 1;
      |                                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:205:33: note: +1, including nesting penalty of 0, nesting level increased to 1
  205 |         const auto v2 = v1 == 2 ? 0 : v1 + 1;
      |                                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:229:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  229 |         if( f00 >= 0 )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:231:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  231 |             if( f01 >= 0 )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:235:13: note: +1, nesting level increased to 2
  235 |             else
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:244:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  244 |                 if( h0 >= 0 )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:248:17: note: +1, nesting level increased to 3
  248 |                 else
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:251:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  251 |                     if( h1 <= 0 )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:255:21: note: +1, nesting level increased to 4
  255 |                     else
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:262:14: note: +1, nesting level increased to 1
  262 |         else if( f01 <= 0 )
      |              ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:264:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  264 |             if( f10 <= 0 )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:269:13: note: +1, nesting level increased to 2
  269 |             else
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:277:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  277 |                 if( h0 >= 0 )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:281:17: note: +1, nesting level increased to 3
  281 |                 else
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:284:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  284 |                     if( h1 <= 0 )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:288:21: note: +1, nesting level increased to 4
  288 |                     else
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:295:14: note: +1, nesting level increased to 1
  295 |         else if( f10 <= 0 )
      |              ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:305:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  305 |             if( h0 >= 0 )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:309:13: note: +1, nesting level increased to 2
  309 |             else
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:312:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  312 |                 if( h1 <= 0 )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:316:17: note: +1, nesting level increased to 3
  316 |                 else
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:322:9: note: +1, nesting level increased to 1
  322 |         else
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:330:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  330 |             if( h0 >= 0 )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:334:13: note: +1, nesting level increased to 2
  334 |             else
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:337:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  337 |                 if( h1 <= 0 )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:341:17: note: +1, nesting level increased to 3
  341 |                 else
      |                 ^

src/geode/geometry/distance.cpp:201:30: warning: [readability-identifier-length]

parameter name 'v0' is too short, expected at least 3 characters
```
  201 |         geode::local_index_t v0 )
      |                              ^
```
src/geode/geometry/distance.cpp:204:20: warning: [readability-identifier-length]

variable name 'v1' is too short, expected at least 3 characters
```
  204 |         const auto v1 = v0 == 2 ? 0 : v0 + 1;
      |                    ^
```
src/geode/geometry/distance.cpp:205:20: warning: [readability-identifier-length]

variable name 'v2' is too short, expected at least 3 characters
```
  205 |         const auto v2 = v1 == 2 ? 0 : v1 + 1;
      |                    ^
```
src/geode/geometry/distance.cpp:207:17: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  207 |         SDEBUG( vertices[v0].get() );
      |                 ^
```
src/geode/geometry/distance.cpp:208:17: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  208 |         SDEBUG( vertices[v1].get() );
      |                 ^
```
src/geode/geometry/distance.cpp:209:17: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  209 |         SDEBUG( vertices[v2].get() );
      |                 ^
```
src/geode/geometry/distance.cpp:210:38: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  210 |         const geode::Vector3D edge0{ vertices[v0], vertices[v1] };
      |                                      ^
```
src/geode/geometry/distance.cpp:210:52: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  210 |         const geode::Vector3D edge0{ vertices[v0], vertices[v1] };
      |                                                    ^
```
src/geode/geometry/distance.cpp:211:38: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  211 |         const geode::Vector3D edge1{ vertices[v0], vertices[v2] };
      |                                      ^
```
src/geode/geometry/distance.cpp:211:52: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  211 |         const geode::Vector3D edge1{ vertices[v0], vertices[v2] };
      |                                                    ^
```
src/geode/geometry/distance.cpp:215:37: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  215 |         const geode::Vector3D diff{ vertices[v0], point };
      |                                     ^
```
src/geode/geometry/distance.cpp:216:20: warning: [readability-identifier-length]

variable name 'b0' is too short, expected at least 3 characters
```
  216 |         const auto b0 = -diff.dot( edge0 );
      |                    ^
```
src/geode/geometry/distance.cpp:217:20: warning: [readability-identifier-length]

variable name 'b1' is too short, expected at least 3 characters
```
  217 |         const auto b1 = -diff.dot( edge1 );
      |                    ^
```

src/geode/geometry/distance.cpp:223:9: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'p'

  223 |         std::array< double, 2 > p0, p1, p;
      |         ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:223:9: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'p0'
```
note: this fix will not be applied because it overlaps with another fix
```
src/geode/geometry/distance.cpp:223:9: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'p1'
```
note: this fix will not be applied because it overlaps with another fix
```
src/geode/geometry/distance.cpp:223:9: warning: [readability-isolate-declaration]

multiple declarations in a single statement reduces readability
```
  223 |         std::array< double, 2 > p0, p1, p;
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
src/geode/geometry/distance.cpp:223:33: warning: [readability-identifier-length]

variable name 'p0' is too short, expected at least 3 characters
```
  223 |         std::array< double, 2 > p0, p1, p;
      |                                 ^
```
src/geode/geometry/distance.cpp:223:37: warning: [readability-identifier-length]

variable name 'p1' is too short, expected at least 3 characters
```
  223 |         std::array< double, 2 > p0, p1, p;
      |                                     ^
```
src/geode/geometry/distance.cpp:224:9: warning: [readability-isolate-declaration]

multiple declarations in a single statement reduces readability
```
  224 |         double dt1, h0, h1;
      |         ^~~~~~~~~~~~~~~~~~~
```

src/geode/geometry/distance.cpp:224:16: warning: [cppcoreguidelines-init-variables]

variable 'dt1' is not initialized

  224 |         double dt1, h0, h1;
      |                ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:224:21: warning: [cppcoreguidelines-init-variables]

variable 'h0' is not initialized

  224 |         double dt1, h0, h1;
      |                     ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:224:21: warning: [readability-identifier-length]

variable name 'h0' is too short, expected at least 3 characters

src/geode/geometry/distance.cpp:224:25: warning: [cppcoreguidelines-init-variables]

variable 'h1' is not initialized

  224 |         double dt1, h0, h1;
      |                         ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:224:25: warning: [readability-identifier-length]

variable name 'h1' is too short, expected at least 3 characters
src/geode/geometry/distance.cpp:349:39: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  349 |         geode::Point3D closest_point{ vertices[v0].get() + edge0 * p[0]
      |                                       ^
```
src/geode/geometry/distance.cpp:354:43: warning: [hicpp-move-const-arg]

std::move of the variable 'closest_point' of the trivially-copyable type 'geode::Point3D' (aka 'Point<3>') has no effect; remove std::move()
```
  354 |         return std::make_tuple( distance, std::move( closest_point ) );
      |                                           ^~~~~~~~~~               ~
```

src/geode/geometry/distance.cpp:359:9: warning: [readability-function-cognitive-complexity]

function 'find_non_colocated_triangles_points' has cognitive complexity of 11 (threshold 10)

  359 |         find_non_colocated_triangles_points( const geode::Triangle3D& triangle0,
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:367:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  367 |         for( const auto vertex0 : geode::LRange{ 3 } )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:369:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  369 |             for( const auto vertex1 : geode::LRange{ 3 } )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:371:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  371 |                 if( geode::point_point_distance(
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:384:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  384 |         for( const auto v : geode::LRange{ 3 } )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:386:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  386 |             if( !colocated.first[v] )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:390:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  390 |             if( !colocated.second[v] )
      |             ^

src/geode/geometry/distance.cpp:372:25: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  372 |                         vertices0[vertex0].get(), vertices1[vertex1].get() )
      |                         ^
```
src/geode/geometry/distance.cpp:372:51: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  372 |                         vertices0[vertex0].get(), vertices1[vertex1].get() )
      |                                                   ^
```
src/geode/geometry/distance.cpp:375:21: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  375 |                     colocated.first[vertex0] = true;
      |                     ^
```
src/geode/geometry/distance.cpp:376:21: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  376 |                     colocated.second[vertex1] = true;
      |                     ^
```
src/geode/geometry/distance.cpp:386:18: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  386 |             if( !colocated.first[v] )
      |                  ^
```
src/geode/geometry/distance.cpp:390:18: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  390 |             if( !colocated.second[v] )
      |                  ^
```

src/geode/geometry/distance.cpp:399:9: warning: [readability-function-cognitive-complexity]

function 'test_triangle_non_common_edges' has cognitive complexity of 15 (threshold 10)

  399 |         test_triangle_non_common_edges(
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:410:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  410 |         for( const auto v0 : geode::LRange{ 3 } )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:412:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  412 |             if( v0 == non_colocated0 )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:418:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  418 |             for( const auto v1 : geode::LRange{ 3 } )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:420:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  420 |                 if( v1 == non_colocated1 )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:428:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  428 |                 if( cur_pt0.inexact_equal( vertices0[v0] )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:429:21: note: +1
  429 |                     || cur_pt1.inexact_equal( vertices1[v1] ) )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:433:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  433 |                 if( cur_distance < min_distance )
      |                 ^

src/geode/geometry/distance.cpp:410:25: warning: [readability-identifier-length]

variable name 'v0' is too short, expected at least 3 characters
```
  410 |         for( const auto v0 : geode::LRange{ 3 } )
      |                         ^
```
src/geode/geometry/distance.cpp:416:43: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  416 |             const geode::Segment3D edge0{ vertices0[non_colocated0],
      |                                           ^
```
src/geode/geometry/distance.cpp:417:17: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  417 |                 vertices0[v0] };
      |                 ^
```
src/geode/geometry/distance.cpp:418:29: warning: [readability-identifier-length]

variable name 'v1' is too short, expected at least 3 characters
```
  418 |             for( const auto v1 : geode::LRange{ 3 } )
      |                             ^
```
src/geode/geometry/distance.cpp:424:47: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  424 |                 const geode::Segment3D edge1{ vertices1[non_colocated1],
      |                                               ^
```
src/geode/geometry/distance.cpp:425:21: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  425 |                     vertices1[v1] };
      |                     ^
```
src/geode/geometry/distance.cpp:428:44: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  428 |                 if( cur_pt0.inexact_equal( vertices0[v0] )
      |                                            ^
```
src/geode/geometry/distance.cpp:429:47: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  429 |                     || cur_pt1.inexact_equal( vertices1[v1] ) )
      |                                               ^
```

src/geode/geometry/distance.cpp:444:58: warning: [readability-function-cognitive-complexity]

function 'test_close_triangles' has cognitive complexity of 12 (threshold 10)

  444 |     std::tuple< double, geode::Point3D, geode::Point3D > test_close_triangles(
      |                                                          ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:453:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  453 |         for( const auto vertex0 : non_colocated_points )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:455:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  455 |             for( const auto vertex1 : non_colocated_points )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:457:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  457 |                 if( vertex0 == vertex1 )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:461:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  461 |                 if( geode::point_point_distance( base_vertices[vertex0].get(),
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:478:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  478 |                 if( cur_distance < min_distance )
      |                 ^

src/geode/geometry/distance.cpp:461:50: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  461 |                 if( geode::point_point_distance( base_vertices[vertex0].get(),
      |                                                  ^
```
src/geode/geometry/distance.cpp:462:25: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  462 |                         base_vertices[vertex1].get() )
      |                         ^
```
src/geode/geometry/distance.cpp:474:46: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  474 |                 const geode::Segment3D edge{ base_vertices[vertex0],
      |                                              ^
```
src/geode/geometry/distance.cpp:475:21: warning: [cppcoreguidelines-pro-bounds-constant-array-index]

do not use array subscript when the index is not an integer constant expression
```
  475 |                     base_vertices[vertex1] };
      |                     ^
```

src/geode/geometry/distance.cpp:493:9: warning: [readability-function-cognitive-complexity]

function 'approximate_segment_segment_distance' has cognitive complexity of 99 (threshold 10)

  493 |         approximate_segment_segment_distance(
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:512:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  512 |         if( ac > bb )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:514:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  514 |             if( std::log2( std::abs( ac ) / std::abs( ac - bb ) ) > 20 )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:521:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  521 |             if( bte <= ctd ) // s <= 0
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:524:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  524 |                 if( e <= 0 ) // t <= 0
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:529:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  529 |                     if( nd >= a )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:533:26: note: +1, nesting level increased to 4
  533 |                     else if( nd > 0 )
      |                          ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:539:22: note: +1, nesting level increased to 3
  539 |                 else if( e < c ) // 0 < t < 1
      |                      ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:544:17: note: +1, nesting level increased to 3
  544 |                 else // t >= 1
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:549:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  549 |                     if( bmd >= a )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:553:26: note: +1, nesting level increased to 4
  553 |                     else if( bmd > 0 )
      |                          ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:560:13: note: +1, nesting level increased to 2
  560 |             else // s > 0
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:562:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  562 |                 if( std::log2( std::abs( bte ) / std::abs( bte - ctd ) ) > 20 )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:567:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  567 |                 if( s >= det ) // s >= 1
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:572:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  572 |                     if( bpe <= 0 ) // t <= 0
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:577:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  577 |                         if( nd <= 0 )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:581:30: note: +1, nesting level increased to 5
  581 |                         else if( nd < a )
      |                              ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:587:26: note: +1, nesting level increased to 4
  587 |                     else if( bpe < c ) // 0 < t < 1
      |                          ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:592:21: note: +1, nesting level increased to 4
  592 |                     else // t >= 1
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:597:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  597 |                         if( bmd <= 0 )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:601:30: note: +1, nesting level increased to 5
  601 |                         else if( bmd < a )
      |                              ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:608:17: note: +1, nesting level increased to 3
  608 |                 else // 0 < s < 1
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:612:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  612 |                     if( ate <= btd ) // t <= 0
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:617:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  617 |                         if( nd <= 0 )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:621:30: note: +1, nesting level increased to 5
  621 |                         else if( nd >= a )
      |                              ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:625:25: note: +1, nesting level increased to 5
  625 |                         else
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:630:21: note: +1, nesting level increased to 4
  630 |                     else // t > 0
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:632:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  632 |                         if( std::log2( std::abs( ate ) / std::abs( ate - btd ) )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:638:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  638 |                         if( t >= det ) // t >= 1
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:643:29: note: +6, including nesting penalty of 5, nesting level increased to 6
  643 |                             if( bmd <= 0 )
      |                             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:647:34: note: +1, nesting level increased to 6
  647 |                             else if( bmd >= a )
      |                                  ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:651:29: note: +1, nesting level increased to 6
  651 |                             else
      |                             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:656:25: note: +1, nesting level increased to 5
  656 |                         else // 0 < t < 1
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:666:9: note: +1, nesting level increased to 1
  666 |         else
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:686:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  686 |             if( e <= 0 ) // t <= 0
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:691:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  691 |                 if( nd <= 0 ) // s <= 0
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:696:22: note: +1, nesting level increased to 3
  696 |                 else if( nd >= a ) // s >= 1
      |                      ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:701:17: note: +1, nesting level increased to 3
  701 |                 else // 0 < s < 1
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:707:18: note: +1, nesting level increased to 2
  707 |             else if( e >= c ) // t >= 1
      |                  ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:712:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  712 |                 if( bmd <= 0 ) // s <= 0
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:717:22: note: +1, nesting level increased to 3
  717 |                 else if( bmd >= a ) // s >= 1
      |                      ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:722:17: note: +1, nesting level increased to 3
  722 |                 else // 0 < s < 1
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:728:13: note: +1, nesting level increased to 2
  728 |             else // 0 < t < 1
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:743:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  743 |         if( distance < geode::GLOBAL_EPSILON )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:750:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  750 |         if( distance_to_closest0 < geode::GLOBAL_EPSILON )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:757:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  757 |         if( distance_to_closest1 < geode::GLOBAL_EPSILON )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:763:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  763 |         if( distance_to_closest0 < distance )
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:765:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  765 |             if( distance_to_closest1 < distance_to_closest0 )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/geometry/distance.cpp:774:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  774 |         if( distance_to_closest1 < distance )
      |         ^

src/geode/geometry/distance.cpp:500:20: warning: [readability-identifier-naming]

invalid case style for variable 'P1mP0'

  500 |         const auto P1mP0 = segment0.direction();
      |                    ^~~~~
      |                    p1m_p0
  501 |         const auto Q1mQ0 = segment1.direction();
  502 |         const geode::Vector< dimension > P0mQ0{ segment1.vertices()[0],
  503 |             segment0.vertices()[0] };
  504 |         const auto a = P1mP0.dot( P1mP0 );
      |                        ~~~~~      ~~~~~
      |                        p1m_p0     p1m_p0
  505 |         const auto b = P1mP0.dot( Q1mQ0 );
      |                        ~~~~~
      |                        p1m_p0
  506 |         const auto c = Q1mQ0.dot( Q1mQ0 );
  507 |         const auto d = P1mP0.dot( P0mQ0 );
      |                        ~~~~~
      |                        p1m_p0

src/geode/geometry/distance.cpp:501:20: warning: [readability-identifier-naming]

invalid case style for variable 'Q1mQ0'

  501 |         const auto Q1mQ0 = segment1.direction();
      |                    ^~~~~
      |                    q1m_q0
  502 |         const geode::Vector< dimension > P0mQ0{ segment1.vertices()[0],
  503 |             segment0.vertices()[0] };
  504 |         const auto a = P1mP0.dot( P1mP0 );
  505 |         const auto b = P1mP0.dot( Q1mQ0 );
      |                                   ~~~~~
      |                                   q1m_q0
  506 |         const auto c = Q1mQ0.dot( Q1mQ0 );
      |                        ~~~~~      ~~~~~
      |                        q1m_q0     q1m_q0
  507 |         const auto d = P1mP0.dot( P0mQ0 );
  508 |         const auto e = Q1mQ0.dot( P0mQ0 );
      |                        ~~~~~
      |                        q1m_q0

src/geode/geometry/distance.cpp:502:42: warning: [readability-identifier-naming]

invalid case style for variable 'P0mQ0'

  502 |         const geode::Vector< dimension > P0mQ0{ segment1.vertices()[0],
      |                                          ^~~~~
      |                                          p0m_q0
  503 |             segment0.vertices()[0] };
  504 |         const auto a = P1mP0.dot( P1mP0 );
  505 |         const auto b = P1mP0.dot( Q1mQ0 );
  506 |         const auto c = Q1mQ0.dot( Q1mQ0 );
  507 |         const auto d = P1mP0.dot( P0mQ0 );
      |                                   ~~~~~
      |                                   p0m_q0
  508 |         const auto e = Q1mQ0.dot( P0mQ0 );
      |                                   ~~~~~
      |                                   p0m_q0

src/geode/geometry/distance.cpp:504:20: warning: [readability-identifier-length]

variable name 'a' is too short, expected at least 3 characters
```
  504 |         const auto a = P1mP0.dot( P1mP0 );
      |                    ^
```
src/geode/geometry/distance.cpp:505:20: warning: [readability-identifier-length]

variable name 'b' is too short, expected at least 3 characters
```
  505 |         const auto b = P1mP0.dot( Q1mQ0 );
      |                    ^
```
src/geode/geometry/distance.cpp:506:20: warning: [readability-identifier-length]

variable name 'c' is too short, expected at least 3 characters
```
  506 |         const auto c = Q1mQ0.dot( Q1mQ0 );
      |                    ^
```
src/geode/geometry/distance.cpp:509:20: warning: [readability-identifier-length]

variable name 'ac' is too short, expected at least 3 characters
```
  509 |         const auto ac = a * c;
      |                    ^
```
src/geode/geometry/distance.cpp:510:20: warning: [readability-identifier-length]

variable name 'bb' is too short, expected at least 3 characters
```
  510 |         const auto bb = b * b;
      |                    ^
```
src/geode/geometry/distance.cpp:511:9: warning: [readability-isolate-declaration]

multiple declarations in a single statement reduces readability
```
  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

src/geode/geometry/distance.cpp:511:16: warning: [cppcoreguidelines-init-variables]

variable 's' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:511:16: warning: [readability-identifier-length]

variable name 's' is too short, expected at least 3 characters

src/geode/geometry/distance.cpp:511:19: warning: [cppcoreguidelines-init-variables]

variable 't' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                   ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:511:22: warning: [cppcoreguidelines-init-variables]

variable 'nd' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                      ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:511:22: warning: [readability-identifier-length]

variable name 'nd' is too short, expected at least 3 characters

src/geode/geometry/distance.cpp:511:26: warning: [cppcoreguidelines-init-variables]

variable 'bmd' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                          ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:511:31: warning: [cppcoreguidelines-init-variables]

variable 'bte' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                               ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:511:36: warning: [cppcoreguidelines-init-variables]

variable 'ctd' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                                    ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:511:41: warning: [cppcoreguidelines-init-variables]

variable 'bpe' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                                         ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:511:46: warning: [cppcoreguidelines-init-variables]

variable 'ate' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                                              ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:511:51: warning: [cppcoreguidelines-init-variables]

variable 'btd' is not initialized

  511 |         double s, t, nd, bmd, bte, ctd, bpe, ate, btd;
      |                                                   ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:514:69: warning: [cppcoreguidelines-avoid-magic-numbers]

20 is a magic number; consider replacing it with a named constant

  514 |             if( std::log2( std::abs( ac ) / std::abs( ac - bb ) ) > 20 )
      |                                                                     ^

src/geode/geometry/distance.cpp:562:76: warning: [cppcoreguidelines-avoid-magic-numbers]

20 is a magic number; consider replacing it with a named constant

  562 |                 if( std::log2( std::abs( bte ) / std::abs( bte - ctd ) ) > 20 )
      |                                                                            ^

src/geode/geometry/distance.cpp:633:31: warning: [cppcoreguidelines-avoid-magic-numbers]

20 is a magic number; consider replacing it with a named constant
```
  633 |                             > 20 )
      |                               ^
```

src/geode/geometry/distance.cpp:738:44: warning: [readability-math-missing-parentheses]

'*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

  738 |             segment0.vertices()[0].get() + P1mP0 * s;
      |                                            ^~~~~~~~~~
      |                                            (        )

src/geode/geometry/distance.cpp:740:44: warning: [readability-math-missing-parentheses]

'*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

  740 |             segment1.vertices()[0].get() + Q1mQ0 * t;
      |                                            ^~~~~~~~~~
      |                                            (        )

src/geode/geometry/distance.cpp:808:33: warning: [readability-math-missing-parentheses]

'*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

  808 |                 current_point + segment_direction * step;
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                 (                       )

src/geode/geometry/distance.cpp:810:33: warning: [readability-math-missing-parentheses]

'*' has higher precedence than '-'; add parentheses to explicitly specify the order of operations

  810 |                 current_point - segment_direction * step;
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                 (                       )

src/geode/geometry/distance.cpp:904:20: warning: [readability-identifier-naming]

invalid case style for variable 'segDirection'

  904 |         const auto segDirection = segment.direction();
      |                    ^~~~~~~~~~~~
      |                    seg_direction
  905 |         const Vector< dimension > diff{ segment.vertices()[0], line.origin() };
  906 |         const auto a00 = line.direction().dot( line.direction() );
  907 |         const auto a01 = -line.direction().dot( segDirection );
      |                                                 ~~~~~~~~~~~~
      |                                                 seg_direction
  908 |         const auto a11 = segDirection.dot( segDirection );
      |                          ~~~~~~~~~~~~      ~~~~~~~~~~~~
      |                          seg_direction     seg_direction
  909 |         const auto b0 = line.direction().dot( diff );
  910 |         const auto det = std::max( a00 * a11 - a01 * a01, 0. );
  911 |         double s0, s1;
  912 | 
  913 |         if( det > 0 )
  914 |         {
  915 |             // The line and segment are not parallel.
  916 |             const auto b1 = -segDirection.dot( diff );
      |                              ~~~~~~~~~~~~
      |                              seg_direction

src/geode/geometry/distance.cpp:909:20: warning: [readability-identifier-length]

variable name 'b0' is too short, expected at least 3 characters
```
  909 |         const auto b0 = line.direction().dot( diff );
      |                    ^
```

src/geode/geometry/distance.cpp:910:36: warning: [readability-math-missing-parentheses]

'*' has higher precedence than '-'; add parentheses to explicitly specify the order of operations

  910 |         const auto det = std::max( a00 * a11 - a01 * a01, 0. );
      |                                    ^~~~~~~~~
      |                                    (        )

src/geode/geometry/distance.cpp:910:48: warning: [readability-math-missing-parentheses]

'*' has higher precedence than '-'; add parentheses to explicitly specify the order of operations

  910 |         const auto det = std::max( a00 * a11 - a01 * a01, 0. );
      |                                                ^~~~~~~~~~
      |                                                (        )

src/geode/geometry/distance.cpp:911:9: warning: [readability-isolate-declaration]

multiple declarations in a single statement reduces readability
```
  911 |         double s0, s1;
      |         ^~~~~~~~~~~~~~
```

src/geode/geometry/distance.cpp:911:16: warning: [cppcoreguidelines-init-variables]

variable 's0' is not initialized

  911 |         double s0, s1;
      |                ^
note: this fix will not be applied because it overlaps with another fix

src/geode/geometry/distance.cpp:911:16: warning: [readability-identifier-length]

variable name 's0' is too short, expected at least 3 characters

src/geode/geometry/distance.cpp:911:20: warning: [cppcoreguidelines-init-variables]

variable 's1' is not initialized

  911 |         double s0, s1;
      |                    ^
note: this fix will not be applied because it overlaps with another fix

Have any feedback or feature suggestions? Share it here.

panquez added 2 commits March 13, 2026 12:41

log

88c72bf

fix(Test): log

664659d

panquez marked this pull request as ready for review March 13, 2026 11:42

github-actions bot changed the base branch from master to next March 13, 2026 11:42

panquez closed this Mar 13, 2026

panquez deleted the test/ci-patch branch March 13, 2026 13:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Test/ci patch#1248

Test/ci patch#1248
panquez wants to merge 2 commits intonextfrom
test/ci-patch

panquez commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

panquez commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Cpp-Linter Report ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant