[Fixes #13954] Error recreating Links via set_resource_default_links

[nrjadkry]

Fixes #13954

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[gemini-code-assist]

Summary of Changes

Hello @nrjadkry, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where Link objects were not being correctly recreated or updated due to an improper use of the url field in database lookup queries. By adjusting the set_resource_default_links function to use more stable identifiers for filtering and moving the url into the defaults for creation/update, the system now correctly manages resource links, preventing unintended duplicates and ensuring proper link management.

Highlights

• Link Recreation Logic Fix: The primary issue addressed is an error in recreating Link objects within the set_resource_default_links function, which previously led to incorrect updates or duplicate entries.
• Modified Link Lookup Criteria: The url field has been removed from the primary filtering criteria in Link.objects.filter() and from the direct arguments of Link.objects.update_or_create() and Link.objects.get_or_create() calls.
• URL Parameter Handling: The url parameter is now consistently passed within the defaults dictionary for update_or_create operations, ensuring that it is only used for setting or updating the URL, rather than for identifying existing links.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• geonode/utils.py
  • Adjusted the set_resource_default_links function to modify how Link objects are queried and updated.
  • Removed url from the filter arguments in Link.objects.filter() calls for various link types (WFS, WCS, HTML, Thumbnail, OGC services).
  • Moved the url parameter into the defaults dictionary for Link.objects.update_or_create() and Link.objects.get_or_create() to ensure it's used for setting values rather than as a lookup key.

Activity

• The pull request author, nrjadkry, created this PR to fix issue Error recreating Links via set_resource_default_links #13954.
• A standard checklist for contributions has been included in the PR description, indicating the initial state of review readiness.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses the issue of recreating links instead of updating them by moving the url field from the lookup parameters to the defaults dictionary in update_or_create and get_or_create calls. This is a good fix that makes link updates more robust. However, I've found one issue in the implementation for legend links where the filter condition has become too broad, which could prevent legend links from being created or updated. Please see my specific comment for details.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.21%. Comparing base (7f6c030) to head (f74ab0c).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13988      +/-   ##
==========================================
+ Coverage   74.07%   74.21%   +0.13%     
==========================================
  Files         950      950              
  Lines       56826    56797      -29     
  Branches     7719     7699      -20     
==========================================
+ Hits        42093    42151      +58     
+ Misses      13044    12951      -93     
- Partials     1689     1695       +6     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.