Skip to content

Conversation

@yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 12, 2025

Description of proposed changes

Use underscores between words in parameter names; related to #2014.

Preview: https://pygmt-dev--4283.org.readthedocs.build/en/4283/api/generated/pygmt.select.html

Guidelines

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added this to the 0.18.0 milestone Dec 12, 2025
@yvonnefroehlich yvonnefroehlich self-assigned this Dec 12, 2025
@yvonnefroehlich yvonnefroehlich added the deprecation Deprecating a feature label Dec 12, 2025
@seisman
Copy link
Member

seisman commented Dec 13, 2025

I'm thinking if mask_grid makes more sense than grid_mask

@yvonnefroehlich
Copy link
Member Author

yvonnefroehlich commented Dec 14, 2025

I'm thinking if mask_grid makes more sense than grid_mask

Hm. I also though a bit about changing the order here and I am unsure what is better. I think having "grid" as first word should indicate that the input to this parameter is a grid. However, for me, mask_grid sounds better.

gridmask (str) – Pass all locations that are inside the valid data area of the grid gridmask. Nodes that are outside are either NaN or zero.


Another aspect is the alias of -N:

  • for pygmt.grdlandmask it is maks_values
  • for pygmt.select it is mask (the GMT docs uses mask_values)

@seisman
Copy link
Member

seisman commented Dec 15, 2025

Another aspect is the alias of -N:

  • for pygmt.grdlandmask it is maks_values
  • for pygmt.select it is mask (the GMT docs uses mask_values)

Yes, this should also be consistent.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 15, 2025
@yvonnefroehlich yvonnefroehlich changed the title pygmt.select: Deprecate parameter gridmask to grid_mask (Will be removed in v0.20.0) pygmt.select: Deprecate parameter gridmask to mask_grid (Will be removed in v0.20.0) Dec 15, 2025
@seisman seisman merged commit 5843664 into main Dec 16, 2025
25 checks passed
@seisman seisman deleted the deprecate-select-gridmask branch December 16, 2025 02:43
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants