Skip to content

bugfix(object): Prevent null pointer dereference in onCollide after object destruction#434

Open
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/object-collide-destroyed-check
Open

bugfix(object): Prevent null pointer dereference in onCollide after object destruction#434
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/object-collide-destroyed-check

Conversation

@seer-by-sentry
Copy link
Copy Markdown

Fixes CLIENT-2JQ. The issue was that: Object::onCollide iterates modules, one destroys 'other' object, subsequent module dereferences invalid 'other' pointer.

  • Added checks in Object::onCollide() to verify if this object or the other colliding object has been destroyed.
  • If an object is destroyed by a previous collide module handler, further collision module processing is stopped.
  • Prevents accessing freed/invalid memory and potential null pointer dereferences during collision handling.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 12548083

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants