Conversation
| # friendly-captcha-client==0.0.2 | ||
|
|
||
| # TODO remove this line when the new SDK version is released | ||
| -e ../.. |
There was a problem hiding this comment.
Is this still necessary? Or is it referencing this SDK (the Python SDK)?
There was a problem hiding this comment.
Yes, it's a reference to the SDK, because we have it fixed to a release and this hasn't been released yet. We could actually just leave it as -e ../.. to always have an up to date SDK in the example without us needing to bump the version but that means that it's not copy-pastable outside of the project for anyone wanting to implement it in their project.
What do you think? We could just add a comment explaining that they need to add friendly-captcha-client==x.y.z. and remove the -e ../..
There was a problem hiding this comment.
Eh, I think it's fine to leave it as -e ../.. and have a comment that says if you use this outside of this project, you should replace this line with friendly-captcha-client==x.y.z
greenberga
force-pushed
the
rok/support-risk-intelligence
branch
from
e784cad to
e878e50
Compare
These validators should now be instance methods rather than class methods.
greenberga
left a comment
greenberga
left a comment
There was a problem hiding this comment.
LGTM! Tested locally and the tests passed. I made a small tweak to schemas.py to fix some deprecation warnings after the version bump of pydantic.
|
Maybe the version requirement for requests can be relaxed to be "greater-than-or-equal", then I think we can close #15 |
3 participants
This PR adds support for risk intelligence on siteverify as well as risk intelligence retrieval from a token.