Skip to content

External wb error cleanup #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chennes merged 1 commit into from
Feb 10, 2026
Merged

External wb error cleanup #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Addon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"import": "Import",
"material": "Material",
"mesh": "Mesh",
"meshpart": "MeshPart",
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new INTERNAL_WORKBENCHES entry will break the unit test test_internal_workbench_list, which loads depends_on_all_workbenches.xml and asserts that it contains every internal workbench. Please update that XML fixture (or relax the assertion) to include a MeshPart dependency so CI remains green.

Copilot uses AI. Check for mistakes.
"openscad": "OpenSCAD",
"part": "Part",
"partdesign": "PartDesign",
Expand Down Expand Up @@ -402,7 +403,7 @@ def extract_metadata_dependencies(self, metadata: Metadata):
fci.Console.PrintWarning(
translate(
"AddonsInstaller",
"{}: Unrecognized internal workbench '{}'",
"{}: Unrecognized internal workbench '{}'\n",
).format(self.name, dep.package)
Comment on lines 405 to 407
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the trailing newline inside the translatable string changes the translation key (msgid) and will drop existing translations for this warning. Prefer keeping the msgid unchanged and append the newline outside translate(...).format(...) when calling PrintWarning.

Copilot uses AI. Check for mistakes.
)
elif dep.dependency_type == DependencyType.addon:
Expand Down
1 change: 1 addition & 0 deletions AddonManagerTest/data/depends_on_all_workbenches.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<depend>Import</depend>
<depend>Material</depend>
<depend>MeshWorkbench</depend>
<depend>MeshPart</depend>
<depend>OpenSCAD Workbench</depend>
<depend>Part WORKBENCH</depend>
<depend>PartDesign WB</depend>
Expand Down
Loading