Skip to content

Conversation

@jguegel
Copy link
Contributor

@jguegel jguegel commented Dec 15, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Added selection for vCard Version, for allowing also sharing contacts with e.g. whatsapp by selecting Version 3.0

Tests performed

  • changed setting and tried exports to different IM

Before & after preview

  • new Setting "vCard Version"
ignoreImageMinify ignoreImageMinify

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@jguegel jguegel requested a review from naveensingh as a code owner December 15, 2025 17:42
@jguegel
Copy link
Contributor Author

jguegel commented Dec 15, 2025

note:
detekt not passing:
VcfExporter.kt:157:17: Function addEvents is nested too deeply. [NestedBlockDepth]
VcfExporter.kt:24:7: Class 'VcfExporter' with '17' functions detected. Defined threshold inside classes is set to '11' [TooManyFunctions]

  • please advise how to "simplify" (i actually only added the getVCardVersion function, but detekt wouldn't let me pass)
  • also likely using string for version not correct, but couldn't make it work with int

please be patient, just trying to help the community, if too much is wrong just close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharing a contact with whatsapp does not work

1 participant