Skip to content

Make FOSS tests more convenient to use#169

Merged
furtib merged 17 commits intoEricsson:mainfrom
furtib:foss_test_refactor
Feb 27, 2026
Merged

Make FOSS tests more convenient to use#169
furtib merged 17 commits intoEricsson:mainfrom
furtib:foss_test_refactor

Conversation

@furtib
Copy link
Contributor

@furtib furtib commented Jan 26, 2026

Why:
FOSS tests left behind a lot of artifacts, which in certain cases blocked the test from running (e.g., after changing bazel version).

What:

  • Added a temporary directory class to common
  • modified test_foss.py to run each test in a temporary folder
  • modified init.sh files to work with temporary folders
  • removed foss test-specific folders from git ignore
  • Updated README.md to reflect these changes

Addresses:
#148

@furtib furtib requested review from Szelethus and nettle January 26, 2026 17:24
@furtib furtib self-assigned this Jan 26, 2026
@furtib furtib added the test ☑️ Adding or refactoring tests label Jan 26, 2026
@furtib furtib force-pushed the foss_test_refactor branch 3 times, most recently from 218b0ef to 86d6d8a Compare January 27, 2026 08:23
@furtib furtib force-pushed the foss_test_refactor branch from 86d6d8a to f74ec27 Compare February 3, 2026 15:59
@furtib furtib requested a review from Szelethus February 4, 2026 09:16
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have a bit more verbosity from the unit test, e.g. "Setting up project XYZ...". I'm running pytest test/foss/ --capture=no and seeing nothing.

@nettle, since you mentioned as an annoying issue, what do you think of this rework?

@furtib furtib force-pushed the foss_test_refactor branch from d68c96a to f977090 Compare February 24, 2026 09:51
@furtib furtib requested a review from Szelethus February 24, 2026 09:51
@furtib furtib force-pushed the foss_test_refactor branch from 7f87440 to 20df522 Compare February 25, 2026 12:52
Copy link
Collaborator

@nettle nettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but please see my comment

Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@furtib furtib merged commit 5f878ac into Ericsson:main Feb 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test ☑️ Adding or refactoring tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants