added click-3x3 feature (closes #719)#720
Open
RealRTTV wants to merge 3 commits intoEarthcomputer:fabricfrom
Open
added click-3x3 feature (closes #719)#720RealRTTV wants to merge 3 commits intoEarthcomputer:fabricfrom
RealRTTV wants to merge 3 commits intoEarthcomputer:fabricfrom
Conversation
xpple
reviewed
Mar 20, 2025
| private Stream<Vector2i> getNeighbours(int x, int y) { | ||
| return Stream.of( | ||
| new Vector2i(x - 1, y - 1), new Vector2i(x, y - 1), new Vector2i(x + 1, y - 1), | ||
| new Vector2i(x - 1, y), new Vector2i(x + 1, y), |
Collaborator
There was a problem hiding this comment.
Suggested change
| new Vector2i(x - 1, y), new Vector2i(x + 1, y), | |
| new Vector2i(x - 1, y), new Vector2i(x + 1, y), |
What is this ungodly amount of whitespace for?
Contributor
Author
There was a problem hiding this comment.
The neighbour tiles are the 8 surrounding, I divided the lines such that the position of the Vector2i is also the position relative to the x and y coordinates of the tile to get the neighbours of, although now I see that IntelliJ screwed me up a lil bit with the x: and y: so I'll edit it to be corrected for when not viewing with those parameter hints.
RealRTTV
commented
Mar 20, 2025
src/main/java/net/earthcomputer/clientcommands/command/MinesweeperCommand.java
Show resolved
Hide resolved
RealRTTV
commented
Mar 20, 2025
src/main/java/net/earthcomputer/clientcommands/command/MinesweeperCommand.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #719.