Skip to content

fix: update success message for service deployment to reflect queued …#3939

Merged
Siumauricio merged 1 commit intocanaryfrom
3827-bulk-deploy-fails-silently-when-deploying-from-docker-image
Mar 8, 2026
Merged

fix: update success message for service deployment to reflect queued …#3939
Siumauricio merged 1 commit intocanaryfrom
3827-bulk-deploy-fails-silently-when-deploying-from-docker-image

Conversation

@Siumauricio
Copy link
Contributor

@Siumauricio Siumauricio commented Mar 8, 2026

…status

What is this PR about?

Please describe in a short paragraph what this PR is about.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #3827

Screenshots (if applicable)

Greptile Summary

This PR corrects a misleading success toast message in the bulk service deployment flow. Previously, the message reported that services were "deployed successfully," which was inaccurate since mutateAsync calls on deployment actions only queue the deployment rather than completing it synchronously. The message now reads "queued for deployment," which is a more accurate reflection of the actual behavior.

  • Changed the success toast message from "${success} service(s) deployed successfully" to "${success} service(s) queued for deployment" in the bulk deploy handler of the environment page.
  • Note: the corresponding error toast message ("failed to deploy") is unchanged and remains reasonable, as it refers to failure at the point of attempting to queue the service.

Confidence Score: 5/5

  • This PR is safe to merge — it is a one-line UX copy fix with no logic changes.
  • The change is a single string literal update in a toast message. No logic, state, or API behavior is modified. The new wording accurately describes the asynchronous queueing behavior of deployment actions.
  • No files require special attention.

Last reviewed commit: 75a4e8e

@Siumauricio Siumauricio linked an issue Mar 8, 2026 that may be closed by this pull request
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 8, 2026
@Siumauricio Siumauricio merged commit ec7df05 into canary Mar 8, 2026
5 checks passed
@Siumauricio Siumauricio deleted the 3827-bulk-deploy-fails-silently-when-deploying-from-docker-image branch March 8, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulk deploy fails silently when deploying from docker image

1 participant