fix: update success message for service deployment to reflect queued …#3939
Merged
Siumauricio merged 1 commit intocanaryfrom Mar 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…status
What is this PR about?
Please describe in a short paragraph what this PR is about.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #3827
Screenshots (if applicable)
Greptile Summary
This PR corrects a misleading success toast message in the bulk service deployment flow. Previously, the message reported that services were "deployed successfully," which was inaccurate since
mutateAsynccalls on deployment actions only queue the deployment rather than completing it synchronously. The message now reads "queued for deployment," which is a more accurate reflection of the actual behavior."${success} service(s) deployed successfully"to"${success} service(s) queued for deployment"in the bulk deploy handler of the environment page."failed to deploy") is unchanged and remains reasonable, as it refers to failure at the point of attempting to queue the service.Confidence Score: 5/5
Last reviewed commit: 75a4e8e