fix: Replace tooltip trigger button for help icon (provider compose ui)#3902
Open
naturedamends wants to merge 6 commits intoDokploy:canaryfrom
Open
fix: Replace tooltip trigger button for help icon (provider compose ui)#3902naturedamends wants to merge 6 commits intoDokploy:canaryfrom
naturedamends wants to merge 6 commits intoDokploy:canaryfrom
Conversation
This is only in one provider but can be extened to other providers
apps/dokploy/components/dashboard/compose/general/generic/save-gitea-provider-compose.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only in one provider but can be extened to other providers
What is this PR about?
Prevents from defaulting to trigger a form submit action on click
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #123
Screenshots (if applicable)
Greptile Summary
This PR fixes a real bug where
<TooltipTrigger>withoutasChildwould default totype="submit"inside a form, causing unintended form submissions when the help icon is clicked. The fix replaces the div-based trigger with a proper<button type="button">and addsasChildto the trigger.Critical issues found:
HelpCirclefromlucide-reactis used on line 417 but not imported. The lucide-react import on line 2 must be updated to includeHelpCircle.<button>block uses mixed spaces and tabs, breaking the file's tab-based indentation consistency.Confidence Score: 1/5
HelpCircleimport will cause a build failure.HelpCircleis used on line 417 but not imported from lucide-react. Additionally, the new button block uses inconsistent indentation (mixed spaces and tabs). Both issues must be resolved before merging.Comments Outside Diff (1)
apps/dokploy/components/dashboard/compose/general/generic/save-gitea-provider-compose.tsx, line 2 (link)HelpCircleis used on line 417 but is never imported in this file. The existing lucide-react import on line 2 only includes{ CheckIcon, ChevronsUpDown, Plus, X }. This will cause a build error.Update the import to include
HelpCircle:Last reviewed commit: 453a7b1
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
Context used:
dashboard- AGENTS.md (source)