Add Extended HE-AAC to AAC WebCodecs Registration#3
Conversation
Adds "mp4a.40.42" (Extended HE-AAC) to the list of fully qualified codec strings, along with a note that Extended HE-AAC should use the "aac" bitstream format. Updates the [ISO14496-3] reference to the 2019 edition and adds new bibliographic references for [ISO23003-3] (USAC) and [ISO23003-4] (DRC). Co-authored-by: Djuffin <132926+Djuffin@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
aac_codec_registration.src.html
Outdated
There was a problem hiding this comment.
It should say:
If {{AudioDecoderConfig/description}} is present, it is assumed to be an AudioSpecificConfig as defined in [iso14496-3] section 1.6.2.1, Table
1.19, and the bitstream is assumed to be in {{AacBitstreamFormat/aac}} format.
There was a problem hiding this comment.
I have updated the AudioDecoderConfig description section to correctly specify Table 1.19, assumed to be an, and in {{AacBitstreamFormat/aac}} format as requested.
Fixes the grammar ("assumed to a" -> "assumed to be an"), updates
the AudioSpecificConfig table reference from 1.15 to 1.19, and
adds "format" after {{AacBitstreamFormat/aac}} as requested by the
reviewer.
Co-authored-by: Djuffin <132926+Djuffin@users.noreply.github.com>
aac_codec_registration.src.html
Outdated
| - `"mp4a.40.5"` — MPEG-4 HE-AAC v1 (AAC LC + SBR) | ||
| - `"mp4a.40.05"` — MPEG-4 HE-AAC v1 (AAC LC + SBR), leading 0 for Aud-OTI compatibility | ||
| - `"mp4a.40.29"` — MPEG-4 HE-AAC v2 (AAC LC + SBR + PS) | ||
| - `"mp4a.40.42"` — Extended HE-AAC (MPEG-D USAC + MPEG-D DRC) as defined in [[iso23003-3]] and [[iso23003-4]] |
There was a problem hiding this comment.
add xHE-AAC in parenthesis
There was a problem hiding this comment.
Added (xHE-AAC) as requested.
aac_codec_registration.src.html
Outdated
| {{EncodedAudioChunk/[[internal data]]}} of {{EncodedAudioChunk}}s are expected | ||
| to be a raw AAC frame (syntax element `raw_data_block()`), as described in | ||
| section 4.4.2.1 of [[iso14496-3]]. | ||
| section 4.4.2.1 of [[iso14496-3]]. Extended HE-AAC shall be in {{AacBitstreamFormat/aac}} format. |
There was a problem hiding this comment.
use "must" instead of "shall"
There was a problem hiding this comment.
Changed "shall" to "must".
- Adds "(xHE-AAC)" to the display name of mp4a.40.42 - Changes "shall" to "must" in EncodedAudioChunk data requirement Co-authored-by: Djuffin <132926+Djuffin@users.noreply.github.com>
1 participant
Adds "mp4a.40.42" (Extended HE-AAC) to the list of fully qualified codec strings, along with a note that Extended HE-AAC should use the "aac" bitstream format. Updates the [ISO14496-3] reference to the 2019 edition and adds new bibliographic references for [ISO23003-3] (USAC) and [ISO23003-4] (DRC).
PR created automatically by Jules for task 12508865787470178836 started by @Djuffin