Fix master detail demos #32198
Merged
Fix master detail demos #32198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the template URL generation for two Angular DataGrid master-detail demo components. The old pattern used a faulty conditional expression that would evaluate to ./false/... when modulePrefix was empty, causing incorrect path resolution.
Changes:
- Corrected templateUrl generation logic in MasterDetailView detail-grid component
- Corrected templateUrl and styleUrls generation logic in AdvancedMasterDetailView detail-view component
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/demos/Demos/DataGrid/MasterDetailView/Angular/app/detail-grid/detail-grid.component.ts | Fixed templateUrl to use simple string interpolation instead of faulty conditional logic |
| apps/demos/Demos/DataGrid/AdvancedMasterDetailView/Angular/app/detail-view/detail-view.component.ts | Fixed both templateUrl and styleUrls to use simple string interpolation instead of faulty conditional logic |
…fix-master-detail-demo-cp
…fix-master-detail-demo-cp
…fix-master-detail-demo-cp
anna-shakhova
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.