Fix Duplicate Findings in Github SAST Scan by Improving Hash Code#13683
Draft
Logicmn wants to merge 10000 commits intoDefectDojo:devfrom
Draft
Fix Duplicate Findings in Github SAST Scan by Improving Hash Code#13683Logicmn wants to merge 10000 commits intoDefectDojo:devfrom
Logicmn wants to merge 10000 commits intoDefectDojo:devfrom
Conversation
…v (docker-compose.yml) (DefectDojo#13386) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…8.0-alpine (docker-compose.yml) (DefectDojo#13385) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…/package.json) (DefectDojo#13382) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…rkflows/test-helm-chart.yml) (DefectDojo#13374) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [social-auth-app-django](https://github.com/python-social-auth/social-app-django) from 5.5.1 to 5.6.0. - [Release notes](https://github.com/python-social-auth/social-app-django/releases) - [Changelog](https://github.com/python-social-auth/social-app-django/blob/master/CHANGELOG.md) - [Commits](python-social-auth/social-app-django@5.5.1...5.6.0) --- updated-dependencies: - dependency-name: social-auth-app-django dependency-version: 5.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…AccountToken feat(helm): Add support for automountServiceAccountToken
…orters-unittests add unit tests to test importer deduplication
…en-endpoint fix: handle broken endpoints when <StartURL> includes a port number in Acunetix XML parser
…backfill-improvements pghistory improvements: backfill and "empty" changes
Release: Merge release into master from: release/2.51.1
Co-authored-by: Ross E Esposito <ross@defectdojo.com>
Bumps [boto3](https://github.com/boto/boto3) from 1.40.66 to 1.40.68. - [Release notes](https://github.com/boto/boto3/releases) - [Commits](boto/boto3@1.40.66...1.40.68) --- updated-dependencies: - dependency-name: boto3 dependency-version: 1.40.68 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…e.json) (DefectDojo#13641) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [asteval](https://github.com/lmfit/asteval) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/lmfit/asteval/releases) - [Commits](lmfit/asteval@1.0.6...1.0.7) --- updated-dependencies: - dependency-name: asteval dependency-version: 1.0.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [django-dbbackup](https://github.com/Archmonger/django-dbbackup) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/Archmonger/django-dbbackup/releases) - [Changelog](https://github.com/Archmonger/django-dbbackup/blob/master/CHANGELOG.md) - [Commits](Archmonger/django-dbbackup@5.0.0...5.0.1) --- updated-dependencies: - dependency-name: django-dbbackup dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [django-crispy-forms](https://github.com/django-crispy-forms/django-crispy-forms) from 2.4 to 2.5. - [Release notes](https://github.com/django-crispy-forms/django-crispy-forms/releases) - [Changelog](https://github.com/django-crispy-forms/django-crispy-forms/blob/main/CHANGELOG.md) - [Commits](django-crispy-forms/django-crispy-forms@2.4...2.5) --- updated-dependencies: - dependency-name: django-crispy-forms dependency-version: '2.5' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* 🎉 Make social auth exceptions configurable * update * fix * update * udpate
[docs] SLAs for Pro
Improve tag handling in importers and add tests for tag imports
Release: Merge release into master from: release/2.52.1
….52.1-2.53.0-dev Release: Merge back 2.52.1 into dev from: master-into-dev/2.52.1-2.53.0-dev
Bumps [boto3](https://github.com/boto/boto3) from 1.40.68 to 1.40.69. - [Release notes](https://github.com/boto/boto3/releases) - [Commits](boto/boto3@1.40.68...1.40.69) --- updated-dependencies: - dependency-name: boto3 dependency-version: 1.40.69 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… v2.4.2 (.github/workflows/release-x-manual-helm-chart.yml) (DefectDojo#13654) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…b/workflows/renovate.yaml) (DefectDojo#13651) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…s/package.json) (DefectDojo#13673) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Member
|
The @Maffooch Another example of where it might be helpful if we would allow parser to calculate a hash based on fields in the report that are not stored in defect dojo. |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an update to the fields used to generate the hash code for Github SAST Scan findings. As explained in this issue, currently the
linefield is used in the hash code. Since these alerts in change lines in GitHub often, it creates duplicate findings for the same alert when re-uploading a scan.To fix this, I propose replacing the
linefield with theurlfield in the hash code. The format of theurlfield is:https://github.com/OWASP/test-repository/security/code-scanning/35This includes the organization, the repository, as well as the alert id. Because the alert id is only unique at the repository level, including only the alert id would not be enough; The organization and repository name is necessary as well. The
urlfield conveniently contains all three. Theurlfield is already populated by the parser, which pulls it from thehtml_urlfield in the GitHub alert. It can be expected that this field will always exist.