Fixed column visibility buttons reordering#159
Open
KarloX2 wants to merge 1 commit intoDataTables:masterfrom
Open
Fixed column visibility buttons reordering#159KarloX2 wants to merge 1 commit intoDataTables:masterfrom
KarloX2 wants to merge 1 commit intoDataTables:masterfrom
Conversation
Previously the new 'data-cv-idx' attribute value was assigned from ´$.inArray( conf.columns, details.mapping )´. Instead ´details.mapping[conf.columns]´ is now used. Moreover, re-sorting the buttons is now only performed when the index really changed.
|
is there a plan to merge this PR? We are affected for the bug. Thanks! |
Collaborator
|
I'm not yet certain this is the correct fix I'm afraid. It does appear to address the issue, but I "feel" there is still an underlying issue that could cause us problems again in future. I need to look into it more, but haven't had a chance to do so yet I'm afraid. It is on the list though. |
jeremyballardmcn
approved these changes
Sep 13, 2019
jeremyballardmcn
left a comment
jeremyballardmcn
left a comment
There was a problem hiding this comment.
This worked! Please merge this request ASAP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the new 'data-cv-idx' attribute value was assigned from "$.inArray(conf.columns, details.mapping)". Instead "details.mapping[conf.columns]" is now used.
Moreover, re-sorting the buttons is now performed only when the index has really changed.
Merging under MIT license is fine for me of course.