Skip to content

Fix JMS1 CLIENT_ACKNOWLEDGE flaky test with high scope iteration keep-alive #10798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 9 commits into from
Mar 12, 2026
Merged

Fix JMS1 CLIENT_ACKNOWLEDGE flaky test with high scope iteration keep-alive #10798

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3f32873
Mark receiving messages with manual acknowledgement as @Flaky for JMS…
bm1549 Mar 10, 2026
86ed7ca
Fix JMS1 CLIENT_ACKNOWLEDGE flaky test by tolerating early scope cleanup
bm1549 Mar 10, 2026
ddc2f0a
Fix JMS1 CLIENT_ACKNOWLEDGE flaky test with low scope iteration keep-…
bm1549 Mar 11, 2026
e3673fd
Retry CI after infrastructure failures
bm1549 Mar 11, 2026
ce2009f
Retry CI - ghcr.io connectivity issue
bm1549 Mar 11, 2026
3d43b74
ci: retrigger pipeline (infrastructure failures)
bm1549 Mar 11, 2026
d879341
fix: restore acknowledge() before assertTraces to fix timeout
bm1549 Mar 12, 2026
d210ea6
fix: restore two-phase assertion with high keep-alive to prevent flak…
bm1549 Mar 12, 2026
5ad44de
ci: retrigger pipeline to resolve SSI infrastructure failures
bm1549 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dd-java-agent/instrumentation/jms/javax-jms-1.1/src/test/groovy/JMS1Test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import datadog.trace.agent.test.naming.VersionedNamingTestBase
import datadog.trace.api.Config
import datadog.trace.api.DDSpanTypes
import datadog.trace.api.Trace
import datadog.trace.api.config.TracerConfig
import datadog.trace.api.config.TraceInstrumentationConfig
import datadog.trace.bootstrap.instrumentation.api.InstrumentationTags
import datadog.trace.bootstrap.instrumentation.api.Tags
Expand Down Expand Up @@ -257,6 +258,9 @@ abstract class JMS1Test extends VersionedNamingTestBase {

def "receiving messages from #destinationType with manual acknowledgement"() {
setup:
// Use a long scope iteration keep-alive to prevent early cleanup of the 3rd
// consumer span, ensuring exactly 5 traces before acknowledge (not 6).
injectSysConfig(TracerConfig.SCOPE_ITERATION_KEEP_ALIVE, "10000")
def destination = destinationType.create(session)
def clientSession = connection.createSession(false, Session.CLIENT_ACKNOWLEDGE)
def producer = session.createProducer(destination)
Expand All @@ -276,7 +280,8 @@ abstract class JMS1Test extends VersionedNamingTestBase {
receivedMessage1.text == messageText1
receivedMessage2.text == messageText2
receivedMessage3.text == messageText3
// only two consume traces will be finished at this point
// only two consume traces will be finished at this point because message 3
// has not been acknowledged and the long keep-alive prevents early cleanup
assertTraces(5) {
producerTraceWithNaming(it, destination)
producerTraceWithNaming(it, destination)
Expand All @@ -300,7 +305,6 @@ abstract class JMS1Test extends VersionedNamingTestBase {
}

cleanup:
receivedMessage3.acknowledge()
producer.close()
consumer.close()
clientSession.close()
Expand Down
Loading