-
Notifications
You must be signed in to change notification settings - Fork 15
Little fixes and improvements in documentation #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xlamorlette-datadog
wants to merge
9
commits into
main
Choose a base branch
from
xlamorlette/documentation-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
895c869
Little fixes and improvements in general documentation
xlamorlette-datadog bc44350
In format script, check that Docker is running
xlamorlette-datadog 5a52bcc
silkeh/clang:14 Docker image doesn't exist for arm64, it only exists …
xlamorlette-datadog 351d058
Documentation: cleaned deprecated references to CircleCI
xlamorlette-datadog 482c52d
Tiny documentation clean up
xlamorlette-datadog a02c20f
Add reference to baggage example
xlamorlette-datadog 45cb80b
Add cpp-reviewers as code owners
xlamorlette-datadog dd0f14c
Merge branch 'main' into xlamorlette/documentation-improvements
xlamorlette-datadog e4632e0
Tiny changes following code review
xlamorlette-datadog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,13 @@ | ||
| /bazel-* | ||
| /.build/ | ||
| /build/ | ||
| /build-*/ | ||
| /.coverage/ | ||
| build/ | ||
|
|
||
| dist/ | ||
| out/ | ||
| MODULE.bazel.lock | ||
| .vscode | ||
| .build/ | ||
| .cache/ | ||
| .coverage/ | ||
| .cursor/ | ||
| .DS_Store | ||
| .install/ | ||
| .vscode | ||
| bazel-* | ||
| build-*/ | ||
| build/ | ||
| dist/ | ||
| MODULE.bazel.lock | ||
| out/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an arm64 machine to test if this will still work for an Apple Silicon dev environment?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I introduced this so that it works on my MacBook M3, because the used
silkeh/clang:14Docker image doesn't exist for arm64, it only exists for amd64. I'm going to add a comment about this.This
--platformoption ofdocker runforces the usage of an amd64 image from an arm64 machine.