-
Notifications
You must be signed in to change notification settings - Fork 123
Feat: Implement ThemeListener for winui3 #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HO-COOH
wants to merge
6
commits into
CommunityToolkit:main
Choose a base branch
from
HO-COOH:feat/winui3-themelistener
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0d51199
Feat: Implement ThemeListener for winui3
HO-COOH 290fdcb
Use CsWin32
HO-COOH 9287da4
code style
Lightczx 1cd0f4b
apply suggestion
Lightczx 4586dee
Revert EOF in MultiTarget.props
HO-COOH 1a9f87e
Merge branch 'main' into feat/winui3-themelistener
Arlodotexe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "$schema": "https://aka.ms/CsWin32.schema.json", | ||
| "allowMarshaling": false, | ||
| "comInterop": { | ||
| "preserveSigMethods": [ | ||
| "*" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| RegisterClassEx | ||
| DefWindowProc | ||
| CreateWindowEx | ||
| WM_SETTINGCHANGE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using Microsoft.Win32; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.InteropServices; | ||
| using Windows.Win32; | ||
| using Windows.Win32.Foundation; | ||
| using Windows.Win32.UI.WindowsAndMessaging; | ||
|
|
||
| namespace CommunityToolkit.WinUI.HelpersRns; | ||
|
|
||
| #if WINAPPSDK | ||
| internal class ThemeListenerHelperWindow | ||
| { | ||
| public delegate void ThemeChangedHandler(ApplicationTheme theme); | ||
|
|
||
| public static ThemeListenerHelperWindow Instance = new(); | ||
|
|
||
| public event ThemeChangedHandler? ThemeChanged; | ||
|
|
||
| private static string s_className = "ThemeListenerHelperWindow"; | ||
|
|
||
| private HWND m_hwnd; | ||
|
|
||
| private ThemeListenerHelperWindow() | ||
| { | ||
| s_className = "ThemeListenerHelperWindow"; | ||
| RegisterClass(); | ||
| m_hwnd = CreateWindow(); | ||
| } | ||
|
|
||
| private static unsafe void RegisterClass() | ||
| { | ||
| WNDCLASSEXW wcx = default; | ||
| wcx.cbSize = (uint)sizeof(WNDCLASSEXW); | ||
| fixed (char* pClassName = s_className) | ||
| { | ||
| wcx.lpszClassName = pClassName; | ||
| wcx.lpfnWndProc = &WndProc; | ||
| if (PInvoke.RegisterClassEx(in wcx) is 0) | ||
| { | ||
| Marshal.ThrowExceptionForHR(Marshal.GetLastPInvokeError()); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static unsafe HWND CreateWindow() | ||
| { | ||
| HWND hwnd = PInvoke.CreateWindowEx(0, s_className, string.Empty, 0, 0, 0, 0, 0, default, null, null, null); | ||
| if (hwnd == HWND.Null) | ||
| { | ||
| Marshal.ThrowExceptionForHR(Marshal.GetLastPInvokeError()); | ||
| } | ||
| return hwnd; | ||
| } | ||
|
|
||
| [UnmanagedCallersOnly(CallConvs = [typeof(CallConvStdcall)])] | ||
| private static LRESULT WndProc(HWND hWnd, uint msg, WPARAM wParam, LPARAM lParam) | ||
| { | ||
| if (msg is PInvoke.WM_SETTINGCHANGE) | ||
| { | ||
| // REG_DWORD | ||
| object? value = Registry.GetValue( | ||
| @"HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Themes\Personalize", | ||
| "AppsUseLightTheme", | ||
| true); | ||
|
|
||
| if (value is int dword) | ||
| { | ||
| Instance.ThemeChanged?.Invoke(dword is 1 ? ApplicationTheme.Light : ApplicationTheme.Dark); | ||
| } | ||
| } | ||
|
|
||
| return PInvoke.DefWindowProc(hWnd, msg, wParam, lParam); | ||
| } | ||
| } | ||
| #endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be conditional to WASDK only, the Helpers component also runs on UWP and Uno Platform. Recommended to re-use
Dependencies.propsinstead of the.csproj.