Enhanced security for Stripe cookie handling#2747
Merged
vytisbulkevicius merged 2 commits intodevelopmentfrom Feb 26, 2026
Merged
Enhanced security for Stripe cookie handling#2747vytisbulkevicius merged 2 commits intodevelopmentfrom
vytisbulkevicius merged 2 commits intodevelopmentfrom
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for f227e63 is ready 🛎️!
|
There was a problem hiding this comment.
Pull request overview
Improves the integrity of guest (non-logged-in) Stripe customer data stored in cookies by adding server-side HMAC validation before trusting cookie contents.
Changes:
- Adds an HMAC cookie (
o_stripe_hmac_data) when persistingo_stripe_datafor unauthenticated users. - Validates
o_stripe_dataagainst the HMAC on read before decoding/using it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+264
to
+270
| if ( isset( $_COOKIE['o_stripe_data'] ) && ! empty( $_COOKIE['o_stripe_data'] ) && isset( $_COOKIE['o_stripe_hmac_data'] ) && ! empty( $_COOKIE['o_stripe_hmac_data'] ) ) { // phpcs:ignore WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___COOKIE | ||
| $data_raw = stripcslashes( $_COOKIE['o_stripe_data'] ); // phpcs:ignore WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___COOKIE, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized | ||
| $hmac_data = sanitize_text_field( $_COOKIE['o_stripe_hmac_data'] ); // phpcs:ignore WordPressVIPMinimum.Variables.RestrictedVariables.cache_constraints___COOKIE | ||
|
|
||
| if ( hash_equals( hash_hmac( 'sha256', $data_raw, wp_salt() ), $hmac_data ) ) { | ||
| $data = json_decode( $data_raw, true ); | ||
| } |
There was a problem hiding this comment.
There are existing PHPUnit tests for Stripe_API, but the new guest-cookie HMAC behavior isn’t covered. Please add unit tests for the unauthenticated path that: (1) reads valid o_stripe_data + o_stripe_hmac_data, (2) returns empty data when the HMAC is missing/invalid, and (3) ideally verifies the cookie-writing path sets both cookies.
Soare-Robert-Daniel
approved these changes
Feb 26, 2026
Contributor
|
🎉 This PR is included in version 3.1.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Codeinwp/otter-internals/issues/267
Summary
Enhanced security for Stripe cookie handling with HMAC validation.
Checklist before the final review