-
Notifications
You must be signed in to change notification settings - Fork 0
[SSF-112] request management frontend #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ed request management frontend
* minor refactoring based on comments * minor changes * prettier
2a49b9a to
3bdc254
Compare
| {pantryName} | ||
| </Text> | ||
|
|
||
| <Tabs.Root mt={5} defaultValue="request details"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is value necessary for any of these Tabs components? and if so, should they be camel case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it determines which tab is open when the modal is opened, if its not set then the modal will just have the tabs. I will change them to camel case though!
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-112
📝 Description
I made the request management page frontend align with the new figma design. This involved refactoring the frontend page and creating a new requestDetailsModal. The frontend path that is relevant is: /request-form/:pantryId.
✔️ Verification
I verified everything worked on the frontend, properly displaying the data from the db and the design aligned with figma.
🏕️ (Optional) Future Work / Notes
NOTE: This branch is based on the SSF-108 PR which is in review as of writing this, so I'd hold off on reviewing this until that is merged. EDIT: Backend has been merged