[SSF 163] - Fix Donation Creation Bug and Improve API Design#128
Open
dburkhart07 wants to merge 6 commits intomainfrom
Open
[SSF 163] - Fix Donation Creation Bug and Improve API Design#128dburkhart07 wants to merge 6 commits intomainfrom
dburkhart07 wants to merge 6 commits intomainfrom
Conversation
dburkhart07
changed the title
sam-schu
requested changes
Mar 19, 2026
apps/backend/src/donationItems/dtos/create-donation-items.dto.ts
Outdated
Show resolved
Hide resolved
| items!: CreateDonationItemDto[]; | ||
| @IsBoolean() | ||
| @IsOptional() | ||
| foodRescue?: boolean; |
Collaborator
There was a problem hiding this comment.
this just wasn't here before at all?
Author
There was a problem hiding this comment.
discussed in slack, making this required, defaulting to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #163
📝 Description
For this PR, I removed the usage of creating multiple donation items, in favor of keeping it all in one spot: the donation service's create endpoint. This now creates all of it in one spot, allowing us to easily verify the creation of donations and donation items all in one transaction. This required minimal frontend changes to properly format and make work. I also removed any usage of reservedQuantity, having that value only be used on creation time of donation items.
I also wrote tests for the create service function, as well as all new tests for the donation item's service.
✔️ Verification