Skip to content

Sk/ssf 150 food request bugs#120

Merged
swarkewalia merged 21 commits intomainfrom
sk/SSF-150-food-request-bugs
Mar 20, 2026
Merged

Sk/ssf 150 food request bugs#120
swarkewalia merged 21 commits intomainfrom
sk/SSF-150-food-request-bugs

Conversation

@swarkewalia
Copy link

ℹ️ Issue
Closes 150

📝 Description
Ensured the “New Request” modal always initializes with empty form fields
Ensured correct fields are filled out when opening 'Resubmit latest' and that additional info is empty if latest request was empty
Resets the error state to avoid stale state between modal openings
✔️ Verification
UI tested

Copy link

@Juwang110 Juwang110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! All bugs seem fixed.

Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to navigate to /request-form to test, I'm getting the error setSelectedItems is not defined

@swarkewalia swarkewalia requested a review from sam-schu March 11, 2026 02:35
Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selected food types still persist in the new request modal

@maxn990 maxn990 requested a review from sam-schu March 12, 2026 14:10
@swarkewalia swarkewalia requested a review from sam-schu March 14, 2026 18:12
Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the alert usages to use the new hook as described here (in the SSF channel from Saturday)?

@swarkewalia swarkewalia requested a review from sam-schu March 19, 2026 03:45
Copy link
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swarkewalia swarkewalia merged commit 92bf686 into main Mar 20, 2026
4 checks passed
@swarkewalia swarkewalia deleted the sk/SSF-150-food-request-bugs branch March 20, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants