Follow frames until we reach a non inlined function in the debug info creation #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
art049
approved these changes
Jan 21, 2026
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
lgtm except the clarity in the comment
Member
|
but nice catch! |
GuillaumeLagrange
force-pushed
the
cod-2054-wrong-file-for-spans-in-walltime-flamegraphs
branch
from
4d4872e to
06d99f2
Compare
GuillaumeLagrange
deleted the
cod-2054-wrong-file-for-spans-in-walltime-flamegraphs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to resolve symbols to their innermost inlined frame, which would locate some user-written code that inlines something from the stdblib inside the stdlib files.