-
Notifications
You must be signed in to change notification settings - Fork 20
fix: instrument-hooks error in CI #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: instrument-hooks error in CI #161
Conversation
Merging this PR will degrade performance by 28%
Performance Changes
Comparing |
bc9eefb to
8a6a81f
Compare
30aa701 to
330f8cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
125 skipped benchmarks, let's look into it before anything
basically all memory benchmarks are skipped if it can help you out
01d254d to
fdd20bd
Compare
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
fdd20bd to
330f8cc
Compare
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
See CodSpeedHQ/instrument-hooks#19