[client-v2, jdbc-v2] Handling of unknown parameters #2712
+267
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
Member
@chernser could you add examples how the following behaviour changed for:
|
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Missing integration test group annotation
Low Severity
The new testCustomSettings() test method uses @Test without groups = {"integration"}, while all other tests in this file that interact with the server have this annotation. The test makes actual server calls via client.queryAll(), so it requires a running ClickHouse instance. Without the integration group annotation, this test may run during unit test phases without a server available, causing unexpected test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
no_throw_on_unknown_configto properties. Parsing happens on.build()custom_sslas it is only for driver)Custom settings should be passed as server settings:
for JDBC:
Note: it is possible to pass initial options with just custom settings prefix but we recommend to use server settings.
When custom settings are passed like this set com.clickhouse.client.api.ClientConfigProperties#CUSTOM_SETTINGS_PREFIX according to your server config. It is important because this is how client determine valid config properties.
Closes #2658
Checklist
Delete items not relevant to your PR:
Note
Introduces strict config validation and custom settings handling across Client and JDBC layers.
CUSTOM_SETTINGS_PREFIXwith defaultcustom_; map keys with this prefix to server settings; validate non-blank prefixClientMisconfigurationException); allow bypass viano_throw_on_unknown_config; addServerException.UNKNOWN_SETTINGfor server-side unknownsssl); exposeDriverProperties.serverSetting(...)/httpHeader(...); prefill driver defaultsgetSetting(...)), SSL handling, expected config sizes; R2DBC test usesserver_time_zoneinstead ofserverTimezoneWritten by Cursor Bugbot for commit 1bb82e5. This will update automatically on new commits. Configure here.