[client-v2, jdbc-v2] queryID auto-generation #2673
Open
+344
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
requested review from
kavirajk and
mzitnik
and removed request for
kavirajk
chernser
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mzitnik
reviewed
Jan 21, 2026
| * @param supplier | ||
| * @return | ||
| */ | ||
| public Builder queryIdGenerator(Supplier<String> supplier) { |
Contributor
There was a problem hiding this comment.
Should be renamed to setQueryIdGenerator
jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/JdbcConfiguration.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Show resolved
Hide resolved
| throw new ClientException("Insert request failed after attempts: " + (maxRetries + 1) + " - Duration: " + durationSince(startTime), lastException); | ||
| }; | ||
|
|
||
| String errMsg = requestExMsg("Insert", retries, durationSince(startTime).toMillis(), requestSettings.getQueryId()); |
There was a problem hiding this comment.
Off-by-one error in retry attempt count message
Low Severity
After exhausting all retries, requestExMsg receives retries instead of retries + 1. The retry loop iterates from i = 0 to i <= retries, making retries + 1 total attempts. Inside the loop, (i + 1) correctly represents the 1-indexed attempt number. However, after the loop, passing retries causes the error message to report one fewer attempt than actually made. The previous code correctly used (maxRetries + 1).
Additional Locations (2)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
queryIdto exception so it is easier to match fail on client and serverServerExceptioncode and query ID are propagated toSQLExceptioncom.clickhouse.jdbc.DriverProperties#QUERY_ID_GENERATORto let set ID generator from JDBC.Closes #2642
Checklist
Delete items not relevant to your PR:
Note
Introduces configurable query ID handling and surfaces it across APIs for better traceability.
Builder.setQueryIdGeneratorand auto-assignsqueryIdforquery/insertwhen not set; error messages now include attempt, duration, andqueryId.ServerExceptionand baseClickHouseExceptionnow carryqueryId; HTTP error parsing/wrapping includesqueryId(HttpAPIClientHelper.readError/wrapException).queryIdviaRecords#getQueryId()andOperationMetrics.DriverProperties#QUERY_ID_GENERATOR;StatementImpl/WriterStatementImplgenerate/setqueryId;JdbcConfigurationplumbs generator.queryIdgeneration/propagation and server error code mapping; minor doc string fix ("through").Written by Cursor Bugbot for commit a75daea. This will update automatically on new commits. Configure here.