Refactor Archiver Client for large requests #196
Draft
+672
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This does sound like a good codeathon task |
Use bodyToFlux Add throwing of ArchiverServiceException Add validation of action response Add unit test for submitAction and other ArchiverService methods
jacomago
force-pushed
the
archclient-large-input
branch
from
f0f092d to
1edb6fe
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the Archiver Client to make sure it can stream large requests.
Also refactored to make it more easily unit testable, realised all the tests were mostly for the processor rather than on the client.
I added some examples for test cases I generated from a test archiver.
Added some more validation of the responses.
For future I'd like to use openapi definition from the archiver to generate a client, maybe that's a good codathon ticket.