Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RtcSctp::do_poll()wherecontinueskips close handling, causing entries to stay inAwaitOpenstate indefinitelyClosedand emitSctpEvent::CloseProblem
When an in-band (DCEP) data channel fails to open with
ErrStreamAlreadyExist, the stream entry hasdo_close = trueset but thecontinuestatement skips the close handling at the bottom of the loop. SincestateremainsAwaitOpen, subsequent polls retry the open — creating an infinite loop of warnings and eventually causing a panic (writing dcep open: ErrPayloadDataStateNotExist).This is triggered when both peers try to open data channels simultaneously and the automatic stream ID allocation conflicts with a stream already opened by the remote peer.
Fix
In
do_poll(), three error paths inside theif want_openblock usedcontinueafter settingdo_close = true, which skipped the close-handling code further down the loop body:configure_reliabilityfailureErrStreamAlreadyExistfor in-band channelsopen_streamerrorsAll three now transition the entry to
Closedand returnSctpEvent::Closedirectly instead ofcontinue-ing.Test plan
cargo test— 0 failures)