fix: better error logging and prevent transactions over total balance#161
Open
fix: better error logging and prevent transactions over total balance#161
Conversation
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
hilljessica8787-dot
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
● Changes
Tests
Build and run the dev server
cd /home/skynet/ztest/WebZjs
just build
yarn dev
Test 1: Transfer validation
Navigate to Transfer/Send screen
Try to send amount > available balance
Expected: Error shown immediately, cannot proceed
Error message shows: "Insufficient balance. Available (after fees): X.XXXXXXXX ZEC"
Test 2: Shield validation
Navigate to Shield Balance screen with < 0.0015 ZEC transparent balance
Expected: Shield button disabled
Error shows: "Minimum balance required: 0.0015 ZEC (includes transaction fees)"
Test 3: Enhanced error messages (if validation bypassed)
Check browser console for detailed error breakdown:
- Full error object logged
- Parsed amounts: Available, Required, Shortfall in both zatoshis and ZEC
- User sees elegant message with exact amounts needed
Test 4: Valid transactions
Try transfer with amount < (balance - fee buffer)
Try shield with balance > 0.0015 ZEC
Expected: Both proceed normally through confirmation and execution
Issues