[ENG-10535] Update the no_login mail send conditions#11620
Merged
cslzchen merged 2 commits intoCenterForOpenScience:feature/notifications-refactor-post-releasefrom Mar 4, 2026
Conversation
cslzchen
approved these changes
Mar 4, 2026
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Fix looks good, let's add unit tests to cover this case. I will create a new ticket.
Note: we also need to update the cut-off time in private config when deploy to test and production server.
cslzchen
changed the title
cslzchen
merged commit 6724230
into
CenterForOpenScience:feature/notifications-refactor-post-release
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Update the no_login mail send conditions.
Changes
Side Effects
QE Notes
CE Notes
Documentation