[ENG-8740] Ability to delete a file from a registration via admin#11285
Open
mkovalua wants to merge 25 commits intoCenterForOpenScience:feature/pbs-25-25from
Open
[ENG-8740] Ability to delete a file from a registration via admin#11285mkovalua wants to merge 25 commits intoCenterForOpenScience:feature/pbs-25-25from
mkovalua wants to merge 25 commits intoCenterForOpenScience:feature/pbs-25-25from
Conversation
…nterForOpenScience#11246) * remove csrf protection from reset password endpoint * update test
[ENG-8656] Clean up password reset throttle error
…NG-8552 Fix/eng 8552
…x/ENG-8743 [ENG-8743] subscribe_osf_general_email settings is not updated
…#11271) * use same logic for admin and web password reset * fix tests
…x/ENG-8742 [ENG-8742] include ignored components when create a view-only link
…om user side to avoid inconsistency
Collaborator
|
@mkovalua Could you rebase this onto the latest |
1 similar comment
Collaborator
|
@mkovalua Could you rebase this onto the latest |
Contributor
Author
|
hi @adlius, I have resolved merge conflicts with |
Contributor
|
LGTM |
Collaborator
|
@mkovalua Could you rebase this onto the latest |
Contributor
Author
|
@Ostap-Zherebetskyi I have rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Frequently users inadvertently include personal identifying information in files associated with Registrations. It becomes imperative for these files to be removed as soon as possible. While any solution to https://openscience.atlassian.net/browse/ENG-8547 would also solve this issue, the most important piece of that analysis is the removal of the file containing the personal identifying information. This function is currently only able to be completed by a Cloud engineer, enabling this function in the admin app would reduce Cloud engineer time and allow for faster resolution to user mistakes with including personal identifying information in files.
Changes
implementation of business logic and UI to delete specified file by guid
Screen.Recording.2025-09-09.at.17.06.41.1.mp4
QA Notes
What are the areas of risk?
Any concerns/considerations/questions that development raised?
not confident about
usage
it looks like
reg.registered_meta[reg.registered_schema._id]may be used properly only for DraftRegistration for nowand
reg.schema_responses.latest('created')will raise Not Exist error if there is no recordmaybe try: except approach is ok, maybe some additional logic is expected
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8740