FIX: Close file handles to prevent descriptor leaks in CI and media parser#1069
Merged
canihavesomecoffee merged 1 commit intoCCExtractor:masterfrom Mar 19, 2026
Merged
Conversation
DhanushVarma-2
requested review from
canihavesomecoffee and
thealphadollar
as code owners
DhanushVarma-2
force-pushed
the
fix/file-handle-leaks
branch
from
3a13330 to
d39d7ed
Compare
canihavesomecoffee
approved these changes
Mar 19, 2026
Replace open().read() with with-statement context managers in mod_ci/controllers.py (4 instances) and mod_sample/media_info_parser.py (1 instance) to prevent file descriptor leaks.
canihavesomecoffee
force-pushed
the
fix/file-handle-leaks
branch
from
d39d7ed to
194dc3f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 places used open().read() without closing the file handle, leaking file descriptors.
In long-running CI processes, this can exhaust the OS file descriptor limit.
Changes:
and rclone config replaced with
with open() as f: f.read()withstatementso it closes after mediainfo completes