refactor decode() and ElementsExtension::ALL#7
Draft
topologoanatom wants to merge 3 commits intomasterfrom
Draft
refactor decode() and ElementsExtension::ALL#7topologoanatom wants to merge 3 commits intomasterfrom
decode() and ElementsExtension::ALL#7topologoanatom wants to merge 3 commits intomasterfrom
Conversation
`decode()` depends on adding `Clone` trait bound to rust-simplicity `BitIter` struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ElementsExtension::ALLarray by enumerating allElementsjets via a const function and manually pushing custom jets.decode()to call the originaldecode()methods forElementsjets while hardcoding the tree path for custom jets. Underlying implementation is fragile since uses unsafe reads due to the lack ofClone.