Consistency update for "Speed up & cancel" page#160
Open
rabbitholiness wants to merge 2 commits intoBitcoinDesign:gh-pagesfrom
Open
Consistency update for "Speed up & cancel" page#160rabbitholiness wants to merge 2 commits intoBitcoinDesign:gh-pagesfrom
rabbitholiness wants to merge 2 commits intoBitcoinDesign:gh-pagesfrom
Conversation
- Transaction detail page is now aligned with activity section - Minor typography and spacing tweaks in the modals
Contributor
Author
|
@GBKS had to commit stuff from upstream. My clone was out of sync. So I hope it didn't break anything. |
Contributor
|
Unfortunately something did get messed up. This PR deletes ~200 images from the site that we still want. I'd recommend copying the files you changed out of the repo, cleaning up your repo, and putting your changes back in and making a new PR. |
Contributor
|
@rabbitholiness forgive me if I lack context, but are the smaller zeros in the amount intentional? It looks fairly different from other bitcoin amount representations in the UI to me 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR aligns the the design of the transaction details page with what we have in the activity section. Check it out in Figma