Add AGENTS.md file to align with AGENTS.md standards#6777
Add AGENTS.md file to align with AGENTS.md standards#6777
Conversation
Co-authored-by: ronniegeraghty <28957151+ronniegeraghty@users.noreply.github.com>
|
@copilot please fix these invalid links: Do not use relative links. Use the full URL links. |
Co-authored-by: ronniegeraghty <28957151+ronniegeraghty@users.noreply.github.com>
Fixed in commit 6c3a77c. All relative links have been replaced with full GitHub URLs in both |
|
@copilot, |
Co-authored-by: ronniegeraghty <28957151+ronniegeraghty@users.noreply.github.com>
... Fixed in commit {commit_hash}. All non-ASCII characters have been replaced with ASCII equivalents:
|
Co-authored-by: RickWinter <4430337+RickWinter@users.noreply.github.com>
|
@ronniegeraghty We should take this as the basis for our agent work. Its not perfect but its better than nothing. We can evolve it over time. |
|
Hi @copilot. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
1 similar comment
|
Hi @copilot. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hey team 👋 — this PR is now out of draft and ready for review. It adds an AGENTS.md file for the C++ SDK repo. Would appreciate a review when you get a chance. Thanks! |
There was a problem hiding this comment.
Pull request overview
Adds repository-level AI agent guidance by introducing a root AGENTS.md aligned to agents.md standards, and cross-links it from the existing Copilot instructions to improve discoverability for automated contributors working in azure-sdk-for-cpp.
Changes:
- Added a new root-level
AGENTS.mddescribing repo purpose, agent boundaries, common workflows, and SDK-specific processes (build/test/codegen/API review). - Updated
.github/copilot-instructions.mdto link to the newAGENTS.mdvia a full GitHub URL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AGENTS.md | New agent guidance document covering repo workflows, structure, and SDK automation topics. |
| .github/copilot-instructions.md | Adds a cross-reference link to AGENTS.md for consolidated guidance. |
Comments suppressed due to low confidence (3)
AGENTS.md:155
- The clang-format command here doesn’t match the repo’s CI formatting check: CI uses
find ./sdk \( -iname '*.hpp' -o -iname '*.cpp' \) ! -iname 'json.hpp' ...(note the parentheses and the exclusion ofjson.hpp). As written, this would also formatsdk/core/azure-core/inc/azure/core/internal/json/json.hpp, which CI explicitly excludes; consider updating this command to mirror the pipeline to avoid contributors reformatting excluded files.
```bash
# Format code using clang-format
# The repository includes a .clang-format configuration
find sdk/ -name "*.cpp" -o -name "*.hpp" | xargs clang-format -i
AGENTS.md:176
- This repository structure overview under
sdk/is missing several top-level service directories that exist in the repo (e.g.,appconfiguration/,attestation/,eventhubs/,tables/). Please update this list so it reflects the currentsdk/layout.
+-- sdk/ # SDK service libraries
+-- core/ # Core libraries (azure-core, azure-core-amqp, etc.)
+-- storage/ # Storage services (blobs, files, queues)
+-- identity/ # Authentication and identity
+-- keyvault/ # Key Vault (keys, secrets, certificates)
+-- template/ # Template for new services
AGENTS.md:193
- The TypeSpec/codegen details here don’t match what’s in this repo: there are
tspconfig.yamlfiles (e.g., under KeyVault packages), but there are notsp-location.yamlfiles in the repository. Also, TypeSpec-generated sources are placed undersrc/generated/(withsrc/private/typically holding internal helpers likepackage_version.hpp), so describing generated code as being insrc/private/is misleading.
- **TypeSpec Projects**: Located in package directories with `tspconfig.yaml` and `tsp-location.yaml` files
- **Configuration**: Service-specific settings in `tspconfig.yaml` define emitter options
- **Generated Code**: Auto-generated code in `src/private/` and header directories
- **TypeSpec Emitter**: Uses `@azure-tools/typespec-cpp` with Azure flavor for code generation
.github/copilot-instructions.mdfileAGENTS.mdfile at repository root following AGENTS.md standards.github/copilot-instructions.mdandAGENTS.mdSummary
Created a comprehensive
AGENTS.mdfile at the repository root that provides guidance for AI agents working with the Azure SDK for C++ repository. The file includes:Also updated
.github/copilot-instructions.mdto cross-reference the newAGENTS.mdfile using full GitHub URLs for discoverability.Latest Changes
Updated the code generation section to reflect that the C++ repository uses TypeSpec with the typespec-cpp emitter (https://github.com/azure/typespec-cpp) rather than AutoRest/Swagger. The section now accurately describes:
Original prompt
Fixes #6776
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.