[AppConfig] az appconfig create/update: Add support to link azure front door profile
#32767
+688,726
−474,435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristineWanjau
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
❌AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| appconfig create | cmd appconfig create added parameter azure_front_door_profile |
||
| appconfig update | cmd appconfig update added parameter azure_front_door_profile |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
avanigupta and
yonzhan
microsoft-github-policy-service
bot
added
App Configuration
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the appconfig command module to link/unlink an Azure Front Door (AFD) profile to an App Configuration store, leveraging newer App Configuration management-plane capabilities.
Changes:
- Bumps
azure-mgmt-appconfigurationdependency to6.0.0b1to access theazureFrontDoormodel surface. - Adds
--azure-front-door-profiletoaz appconfig create/update, wiring it through to the ARM payload. - Adds a scenario test + recording to validate link/unlink behavior, and updates help/linter exclusions accordingly.
Reviewed changes
Copilot reviewed 11 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updates the pinned azure-mgmt-appconfiguration SDK version. |
| src/azure-cli/requirements.py3.windows.txt | Keeps Windows pinned requirements aligned with the new SDK version. |
| src/azure-cli/requirements.py3.Linux.txt | Keeps Linux pinned requirements aligned with the new SDK version. |
| src/azure-cli/requirements.py3.Darwin.txt | Keeps macOS pinned requirements aligned with the new SDK version. |
| src/azure-cli/azure/cli/command_modules/appconfig/custom.py | Adds request payload support for azureFrontDoor.resourceId on create/update. |
| src/azure-cli/azure/cli/command_modules/appconfig/_params.py | Introduces azure_front_door_profile CLI argument for create/update. |
| src/azure-cli/azure/cli/command_modules/appconfig/_help.py | Documents new usage examples for linking/unlinking an AFD profile. |
| src/azure-cli/azure/cli/command_modules/appconfig/linter_exclusions.yml | Adds linter exclusions for the new parameter (and aligns existing ones). |
| src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/test_appconfig_mgmt_commands.py | Adds scenario test coverage for linking/unlinking AFD profile. |
| src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/recordings/test_azconfig_azure_front_door_profile.yaml | New recording for the AFD link/unlink scenario test. |
| src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/recordings/test_azconfig_user_token_audience.yaml | Re-recorded interactions reflecting the new RP api-version/shape. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'azure-mgmt-advisor==9.0.0', | ||
| 'azure-mgmt-apimanagement==4.0.0', | ||
| 'azure-mgmt-appconfiguration==5.0.0', | ||
| 'azure-mgmt-appconfiguration==6.0.0b1', |
There was a problem hiding this comment.
This bumps azure-mgmt-appconfiguration to a beta/preview SDK. That changes the default App Configuration RP api-version used by the module (recordings show a switch to 2025-06-01-preview), which can impact compatibility in sovereign clouds and for other appconfig commands. If the preview api-version is required only for the new Azure Front Door linking feature, consider scoping the preview api-version to only the relevant operations (e.g., create/update when --azure-front-door-profile is used) or explicitly documenting/justifying the global switch in the PR (and verifying cloud support).
Comment on lines
+518
to
+522
| location = 'eastus' | ||
|
|
||
| self.kwargs.update({ | ||
| 'config_store_name': config_store_name, | ||
| 'rg_loc': location, |
There was a problem hiding this comment.
This test overwrites the location argument provided by ResourceGroupPreparer with a hard-coded 'eastus', which makes the scenario less portable and can fail in environments where that region isn't available. Prefer using the injected location (or assign the hard-coded value to a differently named variable like store_location) to avoid shadowing and improve test maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az appconfig create/update
Description
This PR adds support to link azure front door profile to app configuration store.
Testing Guide
History Notes
[App config]
az appconfig create/update: Add support to link azure front door profileThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.