Fix excessive GlyphTypeface allocations in SystemFontCollection when FamilyName differs from requested #20249
+104
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes a cache miss issue in
SystemFontCollectionthat causes repeatedGlyphTypefaceallocations when the platform returns a typeface with a differentFamilyNamethan requested.What is the current behavior?
When requesting a font, the platform may return a typeface with a different
FamilyNamethan requested. For example:FamilyName = "Segoe UI Variable"FamilyName = "Microsoft YaHei UI"The cache stores the typeface under the actual
FamilyName, but subsequent lookups use the requested name. This causes cache misses on every request, creating newGlyphTypefaceinstances (with underlyingHarfBuzzSharp.Facenative resources) repeatedly.This causes significant memory pressure during virtualized list/panel scrolling where the same font is requested many times per second.
What is the updated/expected behavior with this PR?
Typefaces are now cached under the requested family name key, ensuring subsequent lookups hit the cache. Repeated requests return the cached instance instead of allocating new ones.
How was the solution implemented (if it's not obvious)?
The fix ensures
TryAddGlyphTypeface(familyName, key, glyphTypeface)is called with the requestedfamilyNamein both code paths:base.TryGetGlyphTypefacesucceeds_platformImpl.TryCreateGlyphTypefacesucceedsChecklist
Breaking changes
None
Obsoletions / Deprecations
None