[WIP] Expose platform FontFamilyMappings #20140
Closed
+54
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a mechanism to track and expose font family name mappings when the platform font manager returns a different font family than the one requested. This handles cases where font names are aliases or when the system provides alternative fonts.
Key changes:
- Adds a
FontFamilyMappingsproperty toIFontManagerImpl2that exposes a read-only dictionary of requested font names to actual resolved font names - Implements automatic detection and caching of font aliases when the platform returns a different font family than requested
- Modifies
SystemFontCollection.TryGetGlyphTypefaceto use these mappings to cache typefaces under both the requested and actual family names
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/Skia/Avalonia.Skia/FontManagerImpl.cs | Adds _fontFamilyMappings dictionary, implements FontFamilyMappings property, caches installed font names, and populates mappings when platform returns different font family names |
| src/Avalonia.Base/Platform/IFontManagerImpl.cs | Adds FontFamilyMappings property to IFontManagerImpl2 interface |
| src/Avalonia.Base/Media/Fonts/SystemFontCollection.cs | Removes early cache check and adds logic to use font family mappings to cache typefaces under requested alias names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Fixes #20190. |
Contributor
Author
|
Superseeded by: #19852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR introduces a mechanism to track and expose font family name mappings when the platform font manager returns a different font family than the one requested. This handles cases where font names are aliases or when the system provides alternative fonts.
Key changes:
FontFamilyMappingsproperty toIFontManagerImpl2that exposes a read-only dictionary of requested font names to actual resolved font namesSystemFontCollection.TryGetGlyphTypefaceto use these mappings to cache typefaces under both the requested and actual family namesWhat is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues