Fix stack overflow when EnableLowerCamelCase is used (fixes #233)

[joeyadams-bec]

This fixes bug #233, which affects apps that use EnableLowerCamelCase. This regression was introduced in #229, due to the public EDM model using lowercase property names whereas the C# classes use capitalized names.

This fix works by looking up each navigation property's corresponding C# property name. This might not work if the EDM model was built by hand, meaning it omits annotations. If any app still has the stack overflow, we could try changing the ToHashSet calls to use StringComparer.OrdinalIgnoreCase as a fallback.

This pull request also changes all of the tests to use EnableLowerCamelCase, though ideally we'd test both with and without this mode.

[joeyadams-bec]

Two things I wasn't sure about:

1. Should we also use case-insensitive property comparison here? I chose to leave it out for now, and wait to see if someone else reports a stack overflow under the current fix.
2. I changed all of the tests to use EnableLowerCamelCase, but I'm not sure if we want that or not. I suppose a better approach would be to have the test helpers run through multiple ways the OData EDM model can be configured (with/without custom namespace, lowercase or not, etc.), but that would take a lot of refactoring.

[joeyadams-bec]

@dotnet-policy-service agree

[BlaiseD]

Two things I wasn't sure about:

1. Should we also use case-insensitive property comparison here? I chose to leave it out for now, and wait to see if someone else reports a stack overflow under the current fix.
2. I changed all of the tests to use EnableLowerCamelCase, but I'm not sure if we want that or not. I suppose a better approach would be to have the test helpers run through multiple ways the OData EDM model can be configured (with/without custom namespace, lowercase or not, etc.), but that would take a lot of refactoring.

1. Agree. 2. Usually create an override like we've done here and let them both run - not a big deal for this case.

[BlaiseD]

Thanks

[joeyadams-bec]

Thanks. One thing I forgot about: can you check the web tests? I'm not sure how to run those; they abort immediately when I attempt to launch them.

[BlaiseD]

To run the web tests.

• Open the configuration manager and check the Build checkboxes for the web tests and the sample web projects (3 total).
• Start the web projects - they should start with the same ports listed in the inline data on the web tests.
• Then run the web tests.

[joeyadams-bec]

All 69 tests in Web.Tests passed for master with my changes included.

To get the tests to run, I did the following:

• In Configuration Manager, set all projects to build (WebAPI.OData.EFCore, WebAPI.OData.EF6, and Web.Tests were unchecked initially).
• Change the connection strings from Server=.\SQL2016;Database=YourDB to point to my SQL Server.
• Run MigrationTool and SeedDatabase with dotnet run.
• In Configure Startup Projects, choose "Multiple startup projects", and configure WebAPI.OData.EFCore and WebAPI.OData.EF6 to start.

I tested using SQL Server 2022 CU17 (Linux, hosted in Docker).