fix(dingtalk): remove stale card_template_id config entries after adapter refactor (#4590/#4986 context)#5701
Conversation
There was a problem hiding this comment.
嘿,我已经审查了你的更改,一切看起来都很棒!
帮我变得更有用吧!请在每条评论上点 👍 或 👎,我会根据你的反馈改进之后的代码审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此 PR 旨在移除钉钉适配器中已废弃的 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Motivation / 动机
在项目历史上,
#4590曾为钉钉引入过基于card_template_id的互动卡片流式回复能力;但在后续#4986的钉钉适配器重构中,为适配主动消息推送与多媒体发送,项目已弃用原回复方案,也无法继续适配互动卡片流式回复能力,因此card_template_id未继续被运行时使用,保留字段会引起用户误解。This PR removes the stale DingTalk
card_template_idconfiguration entries so that config templates/UI stay consistent with the current runtime behavior after the adapter refactor.Modifications / 改动点
删除钉钉默认配置模板中的
card_template_id:astrbot/core/config/default.py删除后端配置元数据中的
card_template_id:astrbot/core/config/default.py删除 Dashboard 配置元数据中的
card_template_id:dashboard/src/i18n/locales/zh-CN/features/config-metadata.jsondashboard/src/i18n/locales/en-US/features/config-metadata.jsonThis is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Verification Steps:
Result:
rg -n "card_template_id" astrbot dashboard -SResult:
Checklist / 检查清单
requirements.txt和pyproject.toml文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations inrequirements.txtandpyproject.toml.Summary by Sourcery
移除已弃用的 DingTalk
card_template_id配置,以使可用设置与当前适配器行为保持一致。增强内容:
card_template_id字段。card_template_id元数据,使其不再出现在 UI 中。Original summary in English
Summary by Sourcery
Remove deprecated DingTalk card_template_id configuration to align available settings with current adapter behavior.
Enhancements: