This repository was archived by the owner on Mar 26, 2019. It is now read-only.
add prometheus push gateway reporter#51
Open
bdrupieski wants to merge 1 commit intoAppMetrics:devfrom
bdrupieski:feature/push-gateway-reporter
Open
add prometheus push gateway reporter#51bdrupieski wants to merge 1 commit intoAppMetrics:devfrom bdrupieski:feature/push-gateway-reporter
bdrupieski wants to merge 1 commit intoAppMetrics:devfrom
bdrupieski:feature/push-gateway-reporter
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #18.
This is what I've been using for a while to push metrics to a push gateway. I figured I may as well contribute it, but it may not be a good fit here.
.NET Standard 1.6 has
System.Net.Http, but .NET Framework 4.5.2 does not. This usesHttpClientwhich is inSystem.Net.Http. Since App.Metrics.Formatters.Prometheus library targets both, this PR won't build for 4.5.2. I could add that package so that it builds for 4.5.2, but that introduces another dependency for the project.Alternatively it could go into a completely separate App.Metrics.Formatters.Prometheus.PushGateway or something like that, but I don't know if that's worth the trouble for only this.