Skip to content

DPL Analysis: fix topology adjust corner case #15053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Feb 11, 2026
+4 −3
Merged

DPL Analysis: fix topology adjust corner case #15053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Framework/Core/src/ArrowSupport.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,6 @@ o2::framework::ServiceSpec ArrowSupport::arrowBackendSpec()
auto spawner = std::ranges::find_if(workflow, [](DataProcessorSpec const& spec) { return spec.name.starts_with("internal-dpl-aod-spawner"); });
auto analysisCCDB = std::ranges::find_if(workflow, [](DataProcessorSpec const& spec) { return spec.name.starts_with("internal-dpl-aod-ccdb"); });
auto builder = std::ranges::find_if(workflow, [](DataProcessorSpec const& spec) { return spec.name.starts_with("internal-dpl-aod-index-builder"); });
auto reader = std::ranges::find_if(workflow, [](DataProcessorSpec const& spec) { return spec.name.starts_with("internal-dpl-aod-reader"); });
auto writer = std::ranges::find_if(workflow, [](DataProcessorSpec const& spec) { return spec.name.starts_with("internal-dpl-aod-writer"); });
auto& dec = ctx.services().get<DanglingEdgesContext>();
dec.requestedAODs.clear();
Expand Down Expand Up @@ -659,6 +658,9 @@ o2::framework::ServiceSpec ArrowSupport::arrowBackendSpec()
workflow.erase(writer);
}

// removing writer would invalidate the reader iterator if it was created before
auto reader = std::ranges::find_if(workflow, [](DataProcessorSpec const& spec) { return spec.name.starts_with("internal-dpl-aod-reader"); });

if (reader != workflow.end()) {
// If reader and/or builder were adjusted, remove unneeded outputs
// update currently requested AODs
Expand Down
3 changes: 1 addition & 2 deletions run/o2sim_kine_publisher.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "Framework/AnalysisTask.h"
#include "Monitoring/Monitoring.h"
#include "Framework/CommonDataProcessors.h"
#include "SimulationDataFormat/MCTrack.h"
#include "Steer/MCKinematicsReader.h"

#include "Framework/runDataProcessing.h"
Expand Down Expand Up @@ -64,6 +63,6 @@ WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
spec.outputs.emplace_back("MC", "MCHEADER", 0, Lifetime::Timeframe);
spec.outputs.emplace_back("MC", "MCTRACKS", 0, Lifetime::Timeframe);
spec.requiredServices.push_back(o2::framework::ArrowSupport::arrowBackendSpec());
spec.algorithm = CommonDataProcessors::wrapWithRateLimiting(spec.algorithm);
spec.algorithm = CommonDataProcessors::wrapWithTimesliceConsumption(spec.algorithm);
return {spec};
}