Skip to content

Release v15.0.1#470

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
promote/main
Open

Release v15.0.1#470
AdyenAutomationBot wants to merge 1 commit intomainfrom
promote/main

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the library version from 15.0.0 to 15.0.1 across Adyen/settings.py, VERSION, and setup.py. A review comment identifies a version inconsistency with pyproject.toml and recommends consolidating the version number into a single source of truth to improve maintainability and prevent future build issues.

name="Adyen",
packages=find_packages(include=["Adyen*"], exclude=["tests", "tests.*"]),
version="15.0.0",
version="15.0.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version is being updated here to 15.0.1, but it's inconsistent with pyproject.toml, which specifies version = "14.0.0". This file seems to have been missed in the previous release as well.

This inconsistency can lead to incorrect package metadata and build issues, as different tools might read the version from different files. Please update the version in pyproject.toml to 15.0.1.

For better long-term maintainability, I recommend consolidating the version number into a single source of truth. The VERSION file is a good candidate. You can configure setup.py and pyproject.toml to read the version from this file, which would prevent future inconsistencies.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants